2021-05-11 06:06:56

by Zou Wei

Subject: [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/bus/da8xx-mstpri.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
index ee4c023..ff158a1 100644
--- a/drivers/bus/da8xx-mstpri.c
+++ b/drivers/bus/da8xx-mstpri.c
@@ -249,6 +249,7 @@ static const struct of_device_id da8xx_mstpri_of_match[] = {
{ .compatible = "ti,da850-mstpri", },
{ },
};
+MODULE_DEVICE_TABLE(of, da8xx_mstpri_of_match);

static struct platform_driver da8xx_mstpri_driver = {
.probe = da8xx_mstpri_probe,
--
2.6.2

2021-05-12 11:41:53

by Bartosz Golaszewski

Subject: Re: [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE

On Tue, May 11, 2021 at 8:06 AM Zou Wei <[email protected]> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/bus/da8xx-mstpri.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
> index ee4c023..ff158a1 100644
> --- a/drivers/bus/da8xx-mstpri.c
> +++ b/drivers/bus/da8xx-mstpri.c
> @@ -249,6 +249,7 @@ static const struct of_device_id da8xx_mstpri_of_match[] = {
> { .compatible = "ti,da850-mstpri", },
> { },
> };
> +MODULE_DEVICE_TABLE(of, da8xx_mstpri_of_match);
>
> static struct platform_driver da8xx_mstpri_driver = {
> .probe = da8xx_mstpri_probe,
> --
> 2.6.2
>

This module is always built-in. I don't think we require the module
device table for non-dynamic modules.

Bartosz