2021-05-11 13:52:45

by Desmond Cheong Zhi Xi

Subject: [PATCH] Remove link to nonexistent rocket driver docs

Fixes: 3b00b6af7a5b ("tty: rocket, remove the driver")
The rocket driver and documentation were removed in this commit, but
the corresponding entry in index.rst was not removed.

Signed-off-by: Desmond Cheong Zhi Xi <[email protected]>
---
Documentation/driver-api/serial/index.rst | 1 -
1 file changed, 1 deletion(-)

diff --git a/Documentation/driver-api/serial/index.rst b/Documentation/driver-api/serial/index.rst
index 21351b8c95a4..8f7d7af3b90b 100644
--- a/Documentation/driver-api/serial/index.rst
+++ b/Documentation/driver-api/serial/index.rst
@@ -19,7 +19,6 @@ Serial drivers

moxa-smartio
n_gsm
- rocket
serial-iso7816
serial-rs485

--
2.25.1

2021-05-11 17:05:58

by Jonathan Corbet

Subject: Re: [PATCH] Remove link to nonexistent rocket driver docs

Desmond Cheong Zhi Xi <[email protected]> writes:

> Fixes: 3b00b6af7a5b ("tty: rocket, remove the driver")
> The rocket driver and documentation were removed in this commit, but
> the corresponding entry in index.rst was not removed.
>
> Signed-off-by: Desmond Cheong Zhi Xi <[email protected]>

Please note: the "Fixes" tag should be down at the end with your
signoff.

> Documentation/driver-api/serial/index.rst | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/driver-api/serial/index.rst b/Documentation/driver-api/serial/index.rst
> index 21351b8c95a4..8f7d7af3b90b 100644
> --- a/Documentation/driver-api/serial/index.rst
> +++ b/Documentation/driver-api/serial/index.rst
> @@ -19,7 +19,6 @@ Serial drivers
>
> moxa-smartio
> n_gsm
> - rocket
> serial-iso7816
> serial-rs485

Otherwise this looks like a good fix. I've applied it (with Fixes in
the right place), thanks.

jon

2021-05-11 23:53:21

by Desmond Cheong Zhi Xi

Subject: Re: [PATCH] Remove link to nonexistent rocket driver docs

On 11/5/21 1:03 pm, Jonathan Corbet wrote:
> Desmond Cheong Zhi Xi <[email protected]> writes:
>
>> Fixes: 3b00b6af7a5b ("tty: rocket, remove the driver")
>> The rocket driver and documentation were removed in this commit, but
>> the corresponding entry in index.rst was not removed.
>>
>> Signed-off-by: Desmond Cheong Zhi Xi <[email protected]>
>
> Please note: the "Fixes" tag should be down at the end with your
> signoff.
>
>> Documentation/driver-api/serial/index.rst | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/driver-api/serial/index.rst b/Documentation/driver-api/serial/index.rst
>> index 21351b8c95a4..8f7d7af3b90b 100644
>> --- a/Documentation/driver-api/serial/index.rst
>> +++ b/Documentation/driver-api/serial/index.rst
>> @@ -19,7 +19,6 @@ Serial drivers
>>
>> moxa-smartio
>> n_gsm
>> - rocket
>> serial-iso7816
>> serial-rs485
>
> Otherwise this looks like a good fix. I've applied it (with Fixes in
> the right place), thanks.
>
> jon
>

Thanks for the feedback and the amendment, Jon. I will take note in the
future.

Best wishes,
Desmond