2021-06-05 12:37:02

by 赵军奎

Subject: [PATCH] drm/msm: remove no need local variable

Unneeded variable: "ret". Return "0" on line 880

Signed-off-by: Bernard Zhao <[email protected]>
---
drivers/gpu/drm/msm/dp/dp_panel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c
index 9cc816663668..8cb3d016101c 100644
--- a/drivers/gpu/drm/msm/dp/dp_panel.c
+++ b/drivers/gpu/drm/msm/dp/dp_panel.c
@@ -351,7 +351,6 @@ void dp_panel_dump_regs(struct dp_panel *dp_panel)

int dp_panel_timing_cfg(struct dp_panel *dp_panel)
{
- int rc = 0;
u32 data, total_ver, total_hor;
struct dp_catalog *catalog;
struct dp_panel_private *panel;
@@ -404,7 +403,7 @@ int dp_panel_timing_cfg(struct dp_panel *dp_panel)
dp_catalog_panel_timing_cfg(catalog);
panel->panel_on = true;

- return rc;
+ return 0;
}

int dp_panel_init_panel_info(struct dp_panel *dp_panel)
--
2.31.0

2021-06-05 21:35:28

by Stephen Boyd

Subject: Re: [PATCH] drm/msm: remove no need local variable

Quoting Bernard Zhao (2021-06-05 05:35:20)
> Unneeded variable: "ret". Return "0" on line 880

But the variable is "rc".

>
> Signed-off-by: Bernard Zhao <[email protected]>
> ---

Otherwise

Reviewed-by: Stephen Boyd <[email protected]>