2021-08-17 04:15:40

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v2 0/3] can: provide GPIO based termination

changes v2:
- add CAN_TERMINATION_GPIO_MAX
- remove fsl,scu-index from yaml example. It is not used on imx6q

Oleksij Rempel (3):
dt-bindings: can-controller: add support for termination-gpios
dt-bindings: can: fsl,flexcan: enable termination-* bindings
can: dev: provide optional GPIO based termination support

.../bindings/net/can/can-controller.yaml | 9 ++++
.../bindings/net/can/fsl,flexcan.yaml | 17 ++++++
drivers/net/can/dev/dev.c | 54 +++++++++++++++++++
include/linux/can/dev.h | 8 +++
4 files changed, 88 insertions(+)

--
2.30.2


2021-08-17 04:15:52

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v2 1/3] dt-bindings: can-controller: add support for termination-gpios

Some boards provide GPIO controllable termination resistor. Provide
binding to make use of it.

Signed-off-by: Oleksij Rempel <[email protected]>
---
.../devicetree/bindings/net/can/can-controller.yaml | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/can/can-controller.yaml b/Documentation/devicetree/bindings/net/can/can-controller.yaml
index 9cf2ae097156..298ce69a8208 100644
--- a/Documentation/devicetree/bindings/net/can/can-controller.yaml
+++ b/Documentation/devicetree/bindings/net/can/can-controller.yaml
@@ -13,6 +13,15 @@ properties:
$nodename:
pattern: "^can(@.*)?$"

+ termination-gpios:
+ description: GPIO pin to enable CAN bus termination.
+
+ termination-ohms:
+ description: The resistance value of the CAN bus termination resistor.
+ $ref: /schemas/types.yaml#/definitions/uint16-array
+ minimum: 1
+ maximum: 65535
+
additionalProperties: true

...
--
2.30.2

2021-08-18 01:22:03

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 1/3] dt-bindings: can-controller: add support for termination-gpios

On Tue, Aug 17, 2021 at 06:13:04AM +0200, Oleksij Rempel wrote:
> Some boards provide GPIO controllable termination resistor. Provide
> binding to make use of it.
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/net/can/can-controller.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/can-controller.yaml b/Documentation/devicetree/bindings/net/can/can-controller.yaml
> index 9cf2ae097156..298ce69a8208 100644
> --- a/Documentation/devicetree/bindings/net/can/can-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/can/can-controller.yaml
> @@ -13,6 +13,15 @@ properties:
> $nodename:
> pattern: "^can(@.*)?$"
>
> + termination-gpios:
> + description: GPIO pin to enable CAN bus termination.

maxItems: 1

> +
> + termination-ohms:
> + description: The resistance value of the CAN bus termination resistor.
> + $ref: /schemas/types.yaml#/definitions/uint16-array

Standard unit properties already have a type and are uint32.

> + minimum: 1
> + maximum: 65535
> +
> additionalProperties: true
>
> ...
> --
> 2.30.2
>
>