2021-11-04 06:49:36

by CGEL

Subject: [PATCH v2] loop: Remove duplicate assignments

From: luo penghao <[email protected]>

The assignment and operation there will be overwritten later, so
it should be deleted.

The clang_analyzer complains as follows:

drivers/block/loop.c:2330:2 warning:

Value stored to 'err' is never read

change in v2:

Repair the sending email box

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: luo penghao <[email protected]>
---
drivers/block/loop.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 1f91bd4..941b482 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -2329,7 +2329,6 @@ static int loop_add(int i)
goto out_free_dev;
i = err;

- err = -ENOMEM;
lo->tag_set.ops = &loop_mq_ops;
lo->tag_set.nr_hw_queues = 1;
lo->tag_set.queue_depth = 128;
--
2.15.2

2021-11-04 11:49:19

by Jens Axboe

Subject: Re: [PATCH v2] loop: Remove duplicate assignments

On Thu, 4 Nov 2021 06:45:46 +0000, [email protected] wrote:
> From: luo penghao <[email protected]>
>
> The assignment and operation there will be overwritten later, so
> it should be deleted.
>
> The clang_analyzer complains as follows:
>
> [...]

Applied, thanks!

[1/1] loop: Remove duplicate assignments
commit: 18c6c96897a3b1ba44ab4df7324bf0b3454e090b

Best regards,
--
Jens Axboe