2021-12-03 18:59:39

by Arnd Bergmann

Subject: [PATCH] HID: prodikeys: add USB_HID dependency

From: Arnd Bergmann <[email protected]>

Like with the other drivers that recently got fixed, this one
fails to link if USB_HID is disabled or unreachable:

ERROR: modpost: "usb_hid_driver" [drivers/hid/hid-prodikeys.ko] undefined!

Fixes: f237d9028f84 ("HID: add USB_HID dependancy on some USB HID drivers")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/hid/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 74ce789f8636..48d18559670f 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -246,7 +246,7 @@ config HID_MACALLY

config HID_PRODIKEYS
tristate "Prodikeys PC-MIDI Keyboard support"
- depends on HID && SND
+ depends on USB_HID && SND
select SND_RAWMIDI
help
Support for Prodikeys PC-MIDI Keyboard device support.
--
2.29.2

2021-12-06 07:45:25

by Benjamin Tissoires

Subject: Re: [PATCH] HID: prodikeys: add USB_HID dependency

Hi Arnd,

On Fri, Dec 3, 2021 at 8:07 PM Arnd Bergmann <[email protected]> wrote:
>
> From: Arnd Bergmann <[email protected]>
>
> Like with the other drivers that recently got fixed, this one
> fails to link if USB_HID is disabled or unreachable:
>
> ERROR: modpost: "usb_hid_driver" [drivers/hid/hid-prodikeys.ko] undefined!
>
> Fixes: f237d9028f84 ("HID: add USB_HID dependancy on some USB HID drivers")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---

Looks like you already been beaten to it by Greg:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.16/upstream-fixes&id=30cb3c2ad24b66fb7639a6d1f4390c74d6e68f94

But thanks!

Cheers,
Benjamin

> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 74ce789f8636..48d18559670f 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -246,7 +246,7 @@ config HID_MACALLY
>
> config HID_PRODIKEYS
> tristate "Prodikeys PC-MIDI Keyboard support"
> - depends on HID && SND
> + depends on USB_HID && SND
> select SND_RAWMIDI
> help
> Support for Prodikeys PC-MIDI Keyboard device support.
> --
> 2.29.2
>