2022-03-22 12:59:19

by Miaohe Lin

Subject: [PATCH] mm: compaction: use helper isolation_suitable

Use helper isolation_suitable to check whether page is suitable to isolate
to simplify the code. Minor readability improvement.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index c3e37aa9ff9e..86f34053c39d 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -899,7 +899,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
* not falsely conclude that the block should be skipped.
*/
if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages)) {
- if (!cc->ignore_skip_hint && get_pageblock_skip(page)) {
+ if (!isolation_suitable(cc, page)) {
low_pfn = end_pfn;
page = NULL;
goto isolate_abort;
--
2.23.0

2022-03-26 14:05:17

by Wei Yang

Subject: Re: [PATCH] mm: compaction: use helper isolation_suitable

On Tue, Mar 22, 2022 at 07:07:50PM +0800, Miaohe Lin wrote:
>Use helper isolation_suitable to check whether page is suitable to isolate
>to simplify the code. Minor readability improvement.
>
>Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Wei Yang <[email protected]>

>---
> mm/compaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/compaction.c b/mm/compaction.c
>index c3e37aa9ff9e..86f34053c39d 100644
>--- a/mm/compaction.c
>+++ b/mm/compaction.c
>@@ -899,7 +899,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
> * not falsely conclude that the block should be skipped.
> */
> if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages)) {
>- if (!cc->ignore_skip_hint && get_pageblock_skip(page)) {
>+ if (!isolation_suitable(cc, page)) {
> low_pfn = end_pfn;
> page = NULL;
> goto isolate_abort;
>--
>2.23.0

--
Wei Yang
Help you, Help me