2022-03-31 12:25:50

by Daniel Baluta (OSS)

Subject: [PATCH] remoteproc: imx_dsp_rproc: Make rsc_table optional

From: Daniel Baluta <[email protected]>

There are cases when we want to test a simple "hello world"
app on the DSP and we do not need a resource table.

remoteproc core allows us having an optional rsc_table.

Signed-off-by: Daniel Baluta <[email protected]>
---
drivers/remoteproc/imx_dsp_rproc.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
index 2abee78df96e..987ab1add761 100644
--- a/drivers/remoteproc/imx_dsp_rproc.c
+++ b/drivers/remoteproc/imx_dsp_rproc.c
@@ -802,6 +802,14 @@ static void imx_dsp_rproc_kick(struct rproc *rproc, int vqid)
dev_err(dev, "%s: failed (%d, err:%d)\n", __func__, vqid, err);
}

+static int imx_dsp_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
+{
+ if (rproc_elf_load_rsc_table(rproc, fw))
+ dev_warn(&rproc->dev, "no resource table found for this firmware\n");
+
+ return 0;
+}
+
static const struct rproc_ops imx_dsp_rproc_ops = {
.prepare = imx_dsp_rproc_prepare,
.unprepare = imx_dsp_rproc_unprepare,
@@ -809,7 +817,7 @@ static const struct rproc_ops imx_dsp_rproc_ops = {
.stop = imx_dsp_rproc_stop,
.kick = imx_dsp_rproc_kick,
.load = imx_dsp_rproc_elf_load_segments,
- .parse_fw = rproc_elf_load_rsc_table,
+ .parse_fw = imx_dsp_rproc_parse_fw,
.sanity_check = rproc_elf_sanity_check,
.get_boot_addr = rproc_elf_get_boot_addr,
};
--
2.27.0

2022-04-06 15:21:18

by Shengjiu Wang

Subject: RE: [PATCH] remoteproc: imx_dsp_rproc: Make rsc_table optional

>
> There are cases when we want to test a simple "hello world"
> app on the DSP and we do not need a resource table.
>
> remoteproc core allows us having an optional rsc_table.
>
> Signed-off-by: Daniel Baluta <[email protected]>

Acked-by: Shengjiu Wang <[email protected]>

Best regards
Wang Shengjiu

> ---
> drivers/remoteproc/imx_dsp_rproc.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c
> b/drivers/remoteproc/imx_dsp_rproc.c
> index 2abee78df96e..987ab1add761 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -802,6 +802,14 @@ static void imx_dsp_rproc_kick(struct rproc *rproc,
> int vqid)
> dev_err(dev, "%s: failed (%d, err:%d)\n", __func__, vqid,
> err); }
>
> +static int imx_dsp_rproc_parse_fw(struct rproc *rproc, const struct
> +firmware *fw) {
> + if (rproc_elf_load_rsc_table(rproc, fw))
> + dev_warn(&rproc->dev, "no resource table found for this
> firmware\n");
> +
> + return 0;
> +}
> +
> static const struct rproc_ops imx_dsp_rproc_ops = {
> .prepare = imx_dsp_rproc_prepare,
> .unprepare = imx_dsp_rproc_unprepare,
> @@ -809,7 +817,7 @@ static const struct rproc_ops imx_dsp_rproc_ops = {
> .stop = imx_dsp_rproc_stop,
> .kick = imx_dsp_rproc_kick,
> .load = imx_dsp_rproc_elf_load_segments,
> - .parse_fw = rproc_elf_load_rsc_table,
> + .parse_fw = imx_dsp_rproc_parse_fw,
> .sanity_check = rproc_elf_sanity_check,
> .get_boot_addr = rproc_elf_get_boot_addr,
> };
> --
> 2.27.0

2022-04-14 16:11:01

by Mathieu Poirier

Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: Make rsc_table optional

Hi Daniel,

On Thu, Mar 31, 2022 at 01:32:37PM +0300, Daniel Baluta wrote:
> From: Daniel Baluta <[email protected]>
>
> There are cases when we want to test a simple "hello world"
> app on the DSP and we do not need a resource table.
>
> remoteproc core allows us having an optional rsc_table.
>
> Signed-off-by: Daniel Baluta <[email protected]>
> ---
> drivers/remoteproc/imx_dsp_rproc.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
> index 2abee78df96e..987ab1add761 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -802,6 +802,14 @@ static void imx_dsp_rproc_kick(struct rproc *rproc, int vqid)
> dev_err(dev, "%s: failed (%d, err:%d)\n", __func__, vqid, err);
> }
>
> +static int imx_dsp_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
> +{
> + if (rproc_elf_load_rsc_table(rproc, fw))
> + dev_warn(&rproc->dev, "no resource table found for this firmware\n");
> +
> + return 0;
> +}
> +
> static const struct rproc_ops imx_dsp_rproc_ops = {
> .prepare = imx_dsp_rproc_prepare,
> .unprepare = imx_dsp_rproc_unprepare,
> @@ -809,7 +817,7 @@ static const struct rproc_ops imx_dsp_rproc_ops = {
> .stop = imx_dsp_rproc_stop,
> .kick = imx_dsp_rproc_kick,
> .load = imx_dsp_rproc_elf_load_segments,
> - .parse_fw = rproc_elf_load_rsc_table,
> + .parse_fw = imx_dsp_rproc_parse_fw,

Applied.

Thanks,
Mathieu

> .sanity_check = rproc_elf_sanity_check,
> .get_boot_addr = rproc_elf_get_boot_addr,
> };
> --
> 2.27.0
>