2022-05-09 01:24:13

by Colin Ian King

Subject: [PATCH] ALSA: hdsp: remove redundant assignment to pointer kctl

Pointer kctl is being assigned a value that is not being read, buf
is being re-assigned later. The assignment is redundant and can be
removed.

Cleans up clang scan build warning:
sound/pci/rme9652/hdsp.c:3317:28: warning: Although the value stored
to 'kctl' is used in the enclosing expression, the value is never
actually read from 'kctl' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
sound/pci/rme9652/hdsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index 3db641318d3a..dcc43a81ae0e 100644
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -3314,7 +3314,7 @@ static int snd_hdsp_create_controls(struct snd_card *card, struct hdsp *hdsp)
if (hdsp->io_type == RPM) {
/* RPM Bypass, Disconnect and Input switches */
for (idx = 0; idx < ARRAY_SIZE(snd_hdsp_rpm_controls); idx++) {
- err = snd_ctl_add(card, kctl = snd_ctl_new1(&snd_hdsp_rpm_controls[idx], hdsp));
+ err = snd_ctl_add(card, snd_ctl_new1(&snd_hdsp_rpm_controls[idx], hdsp));
if (err < 0)
return err;
}
--
2.35.1

2022-05-09 11:26:33

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hdsp: remove redundant assignment to pointer kctl

On Sun, 08 May 2022 23:28:19 +0200,
Colin Ian King wrote:
>
> Pointer kctl is being assigned a value that is not being read, buf
> is being re-assigned later. The assignment is redundant and can be
> removed.
>
> Cleans up clang scan build warning:
> sound/pci/rme9652/hdsp.c:3317:28: warning: Although the value stored
> to 'kctl' is used in the enclosing expression, the value is never
> actually read from 'kctl' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.


Takashi