Le 17/05/2022 à 11:48, YueHaibing a écrit :
> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
> early_get_first_memblock_info(__va(dt_ptr), &size);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Add missing include file linux/of_fdt.h to fix this.
>
> Signed-off-by: YueHaibing <[email protected]>
Thats for fixing that.
Reviewed-by: Christophe Leroy <[email protected]>
It means we don't have any defconfig for 32 bits booke with
CONFIG_RELOCATABLE ?
> ---
> arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
> index 08a984e29433..093da4dbdee1 100644
> --- a/arch/powerpc/mm/nohash/fsl_book3e.c
> +++ b/arch/powerpc/mm/nohash/fsl_book3e.c
> @@ -36,6 +36,7 @@
> #include <linux/delay.h>
> #include <linux/highmem.h>
> #include <linux/memblock.h>
> +#include <linux/of_fdt.h>
>
> #include <asm/io.h>
> #include <asm/mmu_context.h>
On 2022/5/17 18:45, Christophe Leroy wrote:
>
>
> Le 17/05/2022 à 11:48, YueHaibing a écrit :
>> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
>> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
>> early_get_first_memblock_info(__va(dt_ptr), &size);
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Add missing include file linux/of_fdt.h to fix this.
>>
>> Signed-off-by: YueHaibing <[email protected]>
>
> Thats for fixing that.
>
> Reviewed-by: Christophe Leroy <[email protected]>
>
> It means we don't have any defconfig for 32 bits booke with
> CONFIG_RELOCATABLE ?
Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs
>
>> ---
>> arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
>> index 08a984e29433..093da4dbdee1 100644
>> --- a/arch/powerpc/mm/nohash/fsl_book3e.c
>> +++ b/arch/powerpc/mm/nohash/fsl_book3e.c
>> @@ -36,6 +36,7 @@
>> #include <linux/delay.h>
>> #include <linux/highmem.h>
>> #include <linux/memblock.h>
>> +#include <linux/of_fdt.h>
>>
>> #include <asm/io.h>
>> #include <asm/mmu_context.h>
YueHaibing <[email protected]> writes:
> On 2022/5/17 18:45, Christophe Leroy wrote:
>> Le 17/05/2022 à 11:48, YueHaibing a écrit :
>>> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
>>> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
>>> early_get_first_memblock_info(__va(dt_ptr), &size);
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Add missing include file linux/of_fdt.h to fix this.
>>>
>>> Signed-off-by: YueHaibing <[email protected]>
>>
>> Thats for fixing that.
>>
>> Reviewed-by: Christophe Leroy <[email protected]>
>>
>> It means we don't have any defconfig for 32 bits booke with
>> CONFIG_RELOCATABLE ?
>
> Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs
It's selected by CRASH_DUMP, which is in ppc64_defconfig.
But it's not enabled in corenet32_smp_defconfig which is what I build,
or any of the other 85xx configs.
I guess it should be, I think it's true that RELOCATABLE=y exercises
more interesting code paths?
cheers