2022-07-18 11:11:33

by Xin Gao

Subject: [PATCH] m68k:do not initialise statics to 0.

Delete static variables initialized to 0.

Signed-off-by: Xin Gao <[email protected]>
---
arch/m68k/q40/q40ints.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
index 6886a5d0007b..dfb307ba1185 100644
--- a/arch/m68k/q40/q40ints.c
+++ b/arch/m68k/q40/q40ints.c
@@ -201,8 +201,8 @@ static int ccleirq=60; /* ISA dev IRQs*/
#define DEBUG_Q40INT
/*#define IP_USE_DISABLE *//* would be nice, but crashes ???? */

-static int mext_disabled=0; /* ext irq disabled by master chip? */
-static int aliased_irq=0; /* how many times inside handler ?*/
+static int mext_disabled; /* ext irq disabled by master chip? */
+static int aliased_irq; /* how many times inside handler ?*/


/* got interrupt, dispatch to ISA or keyboard/timer IRQs */
--
2.30.2

2023-01-22 16:33:37

by Geert Uytterhoeven

Subject: Re: [PATCH] m68k:do not initialise statics to 0.

Hi Xin,

On Mon, Jul 18, 2022 at 12:56 PM Xin Gao <[email protected]> wrote:
> Delete static variables initialized to 0.
>
> Signed-off-by: Xin Gao <[email protected]>

Thanks for your patch!

> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -201,8 +201,8 @@ static int ccleirq=60; /* ISA dev IRQs*/
> #define DEBUG_Q40INT
> /*#define IP_USE_DISABLE *//* would be nice, but crashes ???? */
>
> -static int mext_disabled=0; /* ext irq disabled by master chip? */
> -static int aliased_irq=0; /* how many times inside handler ?*/
> +static int mext_disabled; /* ext irq disabled by master chip? */
> +static int aliased_irq; /* how many times inside handler ?*/
>
>
> /* got interrupt, dispatch to ISA or keyboard/timer IRQs */

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in the m68k for-v6.3 branch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds