2022-07-18 21:37:51

by Horatiu Vultur

Subject: [PATCH 0/3] ARM: dts: lan966x: Extend pcb8291.

Extend pcb8291 with different features like, add support to reset the board
using GPIO and add network support.

Horatiu Vultur (3):
ARM: dts: lan966x: Add gpio-restart
ARM: dts: lan966x: Disable can0 on pcb8291
ARM: dts: lan966x: Enable network driver on pcb8291

arch/arm/boot/dts/lan966x-pcb8291.dts | 45 ++++++++++++++++++++++-----
1 file changed, 37 insertions(+), 8 deletions(-)

--
2.33.0

2022-07-18 21:58:05

by Horatiu Vultur

Subject: [PATCH 3/3] ARM: dts: lan966x: Enable network driver on pcb8291

The pcb8291 has 2 ports that are connected to the internal ports of the
switch. Enable them in DT.

Signed-off-by: Horatiu Vultur <[email protected]>
---
arch/arm/boot/dts/lan966x-pcb8291.dts | 35 +++++++++++++++++++++++++++
1 file changed, 35 insertions(+)

diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
index 2cb532aa33f0..d890e6fcdbae 100644
--- a/arch/arm/boot/dts/lan966x-pcb8291.dts
+++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
@@ -4,6 +4,7 @@
*/
/dts-v1/;
#include "lan966x.dtsi"
+#include "dt-bindings/phy/phy-lan966x-serdes.h"

/ {
model = "Microchip EVB - LAN9662";
@@ -32,6 +33,40 @@ fc3_b_pins: fc3-b-pins {
};
};

+&mdio1 {
+ status = "okay";
+};
+
+&phy0 {
+ status = "okay";
+};
+
+&phy1 {
+ status = "okay";
+};
+
+&switch {
+ status = "okay";
+};
+
+&serdes {
+ status = "okay";
+};
+
+&port0 {
+ status = "okay";
+ phy-handle = <&phy0>;
+ phy-mode = "gmii";
+ phys = <&serdes 0 CU(0)>;
+};
+
+&port1 {
+ status = "okay";
+ phy-handle = <&phy1>;
+ phy-mode = "gmii";
+ phys = <&serdes 1 CU(1)>;
+};
+
&flx3 {
atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
status = "okay";
--
2.33.0

2022-07-19 08:02:30

by Claudiu Beznea

Subject: Re: [PATCH 3/3] ARM: dts: lan966x: Enable network driver on pcb8291

On 19.07.2022 00:29, Horatiu Vultur wrote:
> The pcb8291 has 2 ports that are connected to the internal ports of the
> switch. Enable them in DT.
>
> Signed-off-by: Horatiu Vultur <[email protected]>
> ---
> arch/arm/boot/dts/lan966x-pcb8291.dts | 35 +++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 2cb532aa33f0..d890e6fcdbae 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -4,6 +4,7 @@
> */
> /dts-v1/;
> #include "lan966x.dtsi"
> +#include "dt-bindings/phy/phy-lan966x-serdes.h"
>
> / {
> model = "Microchip EVB - LAN9662";
> @@ -32,6 +33,40 @@ fc3_b_pins: fc3-b-pins {
> };
> };
>
> +&mdio1 {
> + status = "okay";
> +};
> +
> +&phy0 {
> + status = "okay";
> +};
> +
> +&phy1 {
> + status = "okay";
> +};
> +
> +&switch {
> + status = "okay";
> +};
> +
> +&serdes {
> + status = "okay";
> +};
> +
> +&port0 {
> + status = "okay";
> + phy-handle = <&phy0>;
> + phy-mode = "gmii";
> + phys = <&serdes 0 CU(0)>;
> +};
> +
> +&port1 {
> + status = "okay";
> + phy-handle = <&phy1>;
> + phy-mode = "gmii";
> + phys = <&serdes 1 CU(1)>;
> +};
> +

Although gpio node is not places where it should be we tend to keep all the
nodes sorted alphabetically. Could you place follow this rule for these new
nodes?

Thank you,
Claudiu Beznea

> &flx3 {
> atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
> status = "okay";

2022-07-19 20:07:32

by Horatiu Vultur

Subject: Re: [PATCH 3/3] ARM: dts: lan966x: Enable network driver on pcb8291

The 07/19/2022 07:58, Claudiu Beznea - M18063 wrote:
> On 19.07.2022 00:29, Horatiu Vultur wrote:
> > The pcb8291 has 2 ports that are connected to the internal ports of the
> > switch. Enable them in DT.
> >
> > Signed-off-by: Horatiu Vultur <[email protected]>
> > ---
> > arch/arm/boot/dts/lan966x-pcb8291.dts | 35 +++++++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > index 2cb532aa33f0..d890e6fcdbae 100644
> > --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> > +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> > @@ -4,6 +4,7 @@
> > */
> > /dts-v1/;
> > #include "lan966x.dtsi"
> > +#include "dt-bindings/phy/phy-lan966x-serdes.h"
> >
> > / {
> > model = "Microchip EVB - LAN9662";
> > @@ -32,6 +33,40 @@ fc3_b_pins: fc3-b-pins {
> > };
> > };
> >
> > +&mdio1 {
> > + status = "okay";
> > +};
> > +
> > +&phy0 {
> > + status = "okay";
> > +};
> > +
> > +&phy1 {
> > + status = "okay";
> > +};
> > +
> > +&switch {
> > + status = "okay";
> > +};
> > +
> > +&serdes {
> > + status = "okay";
> > +};
> > +
> > +&port0 {
> > + status = "okay";
> > + phy-handle = <&phy0>;
> > + phy-mode = "gmii";
> > + phys = <&serdes 0 CU(0)>;
> > +};
> > +
> > +&port1 {
> > + status = "okay";
> > + phy-handle = <&phy1>;
> > + phy-mode = "gmii";
> > + phys = <&serdes 1 CU(1)>;
> > +};
> > +
>
> Although gpio node is not places where it should be we tend to keep all the
> nodes sorted alphabetically. Could you place follow this rule for these new
> nodes?

Yes, I will update in the next version.

>
> Thank you,
> Claudiu Beznea
>
> > &flx3 {
> > atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
> > status = "okay";
>

--
/Horatiu