2022-08-24 07:57:37

by CGEL

Subject: [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value from rtrs_clt_rdma_cq_direct() directly instead of
storing it in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/block/rnbd/rnbd-clt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index 9d01e7ab33e4..78334da74d8b 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1159,10 +1159,8 @@ static int rnbd_rdma_poll(struct blk_mq_hw_ctx *hctx, struct io_comp_batch *iob)
{
struct rnbd_queue *q = hctx->driver_data;
struct rnbd_clt_dev *dev = q->dev;
- int cnt;

- cnt = rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
- return cnt;
+ return rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
}

static void rnbd_rdma_map_queues(struct blk_mq_tag_set *set)
--
2.25.1

2022-08-24 15:06:35

by Jens Axboe

Subject: Re: [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable

On Wed, 24 Aug 2022 07:52:13 +0000, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Return the value from rtrs_clt_rdma_cq_direct() directly instead of
> storing it in another redundant variable.
>
>

Applied, thanks!

[1/1] block/rnbd-clt: Remove the unneeded result variable
commit: f2cc648e12285c53365c2bcacbcd919022f4d3a8

Best regards,
--
Jens Axboe

2022-08-24 15:21:28

by Jinpu Wang

Subject: Re: [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable

On Wed, Aug 24, 2022 at 9:52 AM <[email protected]> wrote:
>
> From: ye xingchen <[email protected]>
>
> Return the value from rtrs_clt_rdma_cq_direct() directly instead of
> storing it in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]
Acked-by: Jack Wang <[email protected]>
thx!
> ---
> drivers/block/rnbd/rnbd-clt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
> index 9d01e7ab33e4..78334da74d8b 100644
> --- a/drivers/block/rnbd/rnbd-clt.c
> +++ b/drivers/block/rnbd/rnbd-clt.c
> @@ -1159,10 +1159,8 @@ static int rnbd_rdma_poll(struct blk_mq_hw_ctx *hctx, struct io_comp_batch *iob)
> {
> struct rnbd_queue *q = hctx->driver_data;
> struct rnbd_clt_dev *dev = q->dev;
> - int cnt;
>
> - cnt = rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
> - return cnt;
> + return rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
> }
>
> static void rnbd_rdma_map_queues(struct blk_mq_tag_set *set)
> --
> 2.25.1