2022-09-24 00:07:35

by John Ogness

Subject: [PATCH printk 02/18] printk: Declare log_wait properly

From: Thomas Gleixner <[email protected]>

kernel/printk/printk.c:365:1: warning: symbol 'log_wait' was not declared. Should it be static?

Signed-off-by: Thomas Gleixner <[email protected]>
Signed-off-by: John Ogness <[email protected]>
Reviewed-by: Sergey Senozhatsky <[email protected]>
---
fs/proc/kmsg.c | 2 --
include/linux/syslog.h | 3 +++
2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c
index b38ad552887f..9d6950ac10fe 100644
--- a/fs/proc/kmsg.c
+++ b/fs/proc/kmsg.c
@@ -18,8 +18,6 @@
#include <linux/uaccess.h>
#include <asm/io.h>

-extern wait_queue_head_t log_wait;
-
static int kmsg_open(struct inode * inode, struct file * file)
{
return do_syslog(SYSLOG_ACTION_OPEN, NULL, 0, SYSLOG_FROM_PROC);
diff --git a/include/linux/syslog.h b/include/linux/syslog.h
index 86af908e2663..955f80e34d4f 100644
--- a/include/linux/syslog.h
+++ b/include/linux/syslog.h
@@ -8,6 +8,8 @@
#ifndef _LINUX_SYSLOG_H
#define _LINUX_SYSLOG_H

+#include <linux/wait.h>
+
/* Close the log. Currently a NOP. */
#define SYSLOG_ACTION_CLOSE 0
/* Open the log. Currently a NOP. */
@@ -35,5 +37,6 @@
#define SYSLOG_FROM_PROC 1

int do_syslog(int type, char __user *buf, int count, int source);
+extern wait_queue_head_t log_wait;

#endif /* _LINUX_SYSLOG_H */
--
2.30.2

2022-09-26 15:53:54

by Petr Mladek

Subject: Re: [PATCH printk 02/18] printk: Declare log_wait properly

On Sat 2022-09-24 02:10:38, John Ogness wrote:
> From: Thomas Gleixner <[email protected]>
>
> kernel/printk/printk.c:365:1: warning: symbol 'log_wait' was not declared. Should it be static?
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Signed-off-by: John Ogness <[email protected]>
> Reviewed-by: Sergey Senozhatsky <[email protected]>

Reviewed-by: Petr Mladek <[email protected]>

Best Regards,
Petr