LinuxLists.cc - [PATCH 5/5] MAINTAINERS: Update pstore maintainers

2022-10-11 20:38:52

Subject: [PATCH 5/5] MAINTAINERS: Update pstore maintainers

Update pstore to better reflect reality of active contributors:

- Remove Anton and Colin (thank you for your help through the years!)
- Move Tony to Reviewer
- Add Guilherme as Reviewer
- Add mailing list
- Upgrade to Supported

Signed-off-by: Kees Cook <[email protected]>
---
MAINTAINERS | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9d7f64dc0efe..bb18a6c91c4e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16458,10 +16458,10 @@ F: net/psample

PSTORE FILESYSTEM
M: Kees Cook <[email protected]>
-M: Anton Vorontsov <[email protected]>
-M: Colin Cross <[email protected]>
-M: Tony Luck <[email protected]>
-S: Maintained
+R: Tony Luck <[email protected]>
+R: Guilherme G. Piccoli <[email protected]>
+L: [email protected]
+S: Supported
T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
F: Documentation/admin-guide/ramoops.rst
F: Documentation/admin-guide/pstore-blk.rst
--
2.34.1

2022-10-11 20:39:49

by Colin Cross

[permalink] [raw]

Subject: Re: [PATCH 5/5] MAINTAINERS: Update pstore maintainers

On Tue, Oct 11, 2022 at 1:01 PM Kees Cook <[email protected]> wrote:
>
> Update pstore to better reflect reality of active contributors:
>
> - Remove Anton and Colin (thank you for your help through the years!)
> - Move Tony to Reviewer
> - Add Guilherme as Reviewer
> - Add mailing list
> - Upgrade to Supported
>
> Signed-off-by: Kees Cook <[email protected]>
> ---
> MAINTAINERS | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9d7f64dc0efe..bb18a6c91c4e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16458,10 +16458,10 @@ F: net/psample
>
> PSTORE FILESYSTEM
> M: Kees Cook <[email protected]>
> -M: Anton Vorontsov <[email protected]>
> -M: Colin Cross <[email protected]>
> -M: Tony Luck <[email protected]>
> -S: Maintained
> +R: Tony Luck <[email protected]>
> +R: Guilherme G. Piccoli <[email protected]>
> +L: [email protected]
> +S: Supported
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
> F: Documentation/admin-guide/ramoops.rst
> F: Documentation/admin-guide/pstore-blk.rst
> --
> 2.34.1
>

Acked-by: Colin Cross <[email protected]>

2022-10-11 20:42:52

by Guilherme G. Piccoli

[permalink] [raw]

Subject: Re: [PATCH 5/5] MAINTAINERS: Update pstore maintainers

2022-10-11 22:49:33

by Kees Cook

[permalink] [raw]

Subject: Re: [PATCH 5/5] MAINTAINERS: Update pstore maintainers

On Tue, Oct 11, 2022 at 05:35:48PM -0300, Guilherme G. Piccoli wrote:
> On 11/10/2022 17:01, Kees Cook wrote:
> > +L: [email protected]
>
> Just curious, why linux-hardening was the picked list?

It's where the bulk of other things I work on end up living, and there's
an active patchwork instance, so it'll do patch lifetime tracking for
us:
https://patchwork.kernel.org/project/linux-hardening/list/

--
Kees Cook

2022-10-12 15:20:43

by Guilherme G. Piccoli

[permalink] [raw]

Subject: Re: [PATCH 5/5] MAINTAINERS: Update pstore maintainers

On 11/10/2022 19:20, Kees Cook wrote:
> On Tue, Oct 11, 2022 at 05:35:48PM -0300, Guilherme G. Piccoli wrote:
>> On 11/10/2022 17:01, Kees Cook wrote:
>>> +L: [email protected]
>>
>> Just curious, why linux-hardening was the picked list?
>
> It's where the bulk of other things I work on end up living, and there's
> an active patchwork instance, so it'll do patch lifetime tracking for
> us:
> https://patchwork.kernel.org/project/linux-hardening/list/
>

Makes sense, and very nice that it has the patchwork set!
Thanks,

Guilherme

2022-11-16 15:52:12

by Guilherme G. Piccoli

[permalink] [raw]

Subject: Re: [PATCH 5/5] MAINTAINERS: Update pstore maintainers

On 11/10/2022 17:01, Kees Cook wrote:
> Update pstore to better reflect reality of active contributors:
>
> - Remove Anton and Colin (thank you for your help through the years!)
> - Move Tony to Reviewer
> - Add Guilherme as Reviewer
> - Add mailing list
> - Upgrade to Supported
>
> Signed-off-by: Kees Cook <[email protected]>
> ---
> MAINTAINERS | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Hi Kees, sorry to revamp this thread for a "tangential" topic, but it
feels a "kinda" proper thread.

Since I was added as a reviewer on pstore (in linux-next so far), I
started to receive a bunch of emails from ARM device-tree folks; they're
adding ramoops entries to their DTs and looping pstore folks.

Examples:

https://lore.kernel.org/linux-hardening/[email protected]/

https://lore.kernel.org/linux-hardening/[email protected]/

Personally, I have no knowledge of these HW to evaluate if the ramoops
setting is appropriate, so they're nop from my side, I just delete them.
But that raises the question - are you/Tony reviewing this kind of
change? It's not related to pstore/ramoops code, it's just users setting
ramoops in their DTs, so seems to me a bit far from the purpose of the
pstore entry.

What do you/Tony think about that? Likely the DT folks are following
this entry in the MAINTAINERS to send these emails:

PSTORE FILESYSTEM
M: Kees Cook <[email protected]>
[...]
F: include/linux/pstore*
K: \b(pstore|ramoops) <------

Should this be kept? Maybe only the ramoops entry could be removed?

Again, totally fine be me to keep'em, it's just that I'm receiving and
ignoring the emails, so if everybody else is doing the same, better to
just remove this entry from MAINTAINERS.

Thanks,

Guilherme

2022-11-17 22:32:19

by Kees Cook

[permalink] [raw]

Subject: Re: [PATCH 5/5] MAINTAINERS: Update pstore maintainers

On Wed, Nov 16, 2022 at 12:42:53PM -0300, Guilherme G. Piccoli wrote:
> On 11/10/2022 17:01, Kees Cook wrote:
> > Update pstore to better reflect reality of active contributors:
> >
> > - Remove Anton and Colin (thank you for your help through the years!)
> > - Move Tony to Reviewer
> > - Add Guilherme as Reviewer
> > - Add mailing list
> > - Upgrade to Supported
> >
> > Signed-off-by: Kees Cook <[email protected]>
> > ---
> > MAINTAINERS | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Hi Kees, sorry to revamp this thread for a "tangential" topic, but it
> feels a "kinda" proper thread.
>
> Since I was added as a reviewer on pstore (in linux-next so far), I
> started to receive a bunch of emails from ARM device-tree folks; they're
> adding ramoops entries to their DTs and looping pstore folks.
>
> Examples:
>
> https://lore.kernel.org/linux-hardening/[email protected]/
>
> https://lore.kernel.org/linux-hardening/[email protected]/
>
>
> Personally, I have no knowledge of these HW to evaluate if the ramoops
> setting is appropriate, so they're nop from my side, I just delete them.
> But that raises the question - are you/Tony reviewing this kind of
> change? It's not related to pstore/ramoops code, it's just users setting
> ramoops in their DTs, so seems to me a bit far from the purpose of the
> pstore entry.

I usually look at it very quickly, but I can't meaningfully positively
review it because I don't know the hardware, etc.

> What do you/Tony think about that? Likely the DT folks are following
> this entry in the MAINTAINERS to send these emails:
>
> PSTORE FILESYSTEM
> M: Kees Cook <[email protected]>
> [...]
> F: include/linux/pstore*
> K: \b(pstore|ramoops) <------
>
> Should this be kept? Maybe only the ramoops entry could be removed?

I would like to keep it -- if something mentions pstore and ramoops, I'd
like to see it. I can't review all of it, but I'd like it to at least
show up in my inbox. :)

--
Kees Cook

2022-11-17 22:54:47

by Guilherme G. Piccoli

[permalink] [raw]

Subject: Re: [PATCH 5/5] MAINTAINERS: Update pstore maintainers

On 17/11/2022 19:01, Kees Cook wrote:
> [...]
>> PSTORE FILESYSTEM
>> M: Kees Cook <[email protected]>
>> [...]
>> F: include/linux/pstore*
>> K: \b(pstore|ramoops) <------
>>
>> Should this be kept? Maybe only the ramoops entry could be removed?
>
> I would like to keep it -- if something mentions pstore and ramoops, I'd
> like to see it. I can't review all of it, but I'd like it to at least
> show up in my inbox. :)
>

Totally fine by me, was curious and now I understand this is not legacy,
but something of your interest indeed.
Thanks for the prompt response!

Cheers,

Guilherme