2022-11-03 08:22:19

by Tang Bin

Subject: [PATCH] net: libwx: Remove variable dev to simplify code

In the function wx_get_pcie_msix_counts(), the variable dev
is redundant, so remove it.

Signed-off-by: Tang Bin <[email protected]>
---
drivers/net/ethernet/wangxun/libwx/wx_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
index 1eb7388f1..a7d79490e 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
@@ -883,13 +883,12 @@ EXPORT_SYMBOL(wx_reset_misc);
int wx_get_pcie_msix_counts(struct wx_hw *wxhw, u16 *msix_count, u16 max_msix_count)
{
struct pci_dev *pdev = wxhw->pdev;
- struct device *dev = &pdev->dev;
int pos;

*msix_count = 1;
pos = pci_find_capability(pdev, PCI_CAP_ID_MSIX);
if (!pos) {
- dev_err(dev, "Unable to find MSI-X Capabilities\n");
+ dev_err(&pdev->dev, "Unable to find MSI-X Capabilities\n");
return -EINVAL;
}
pci_read_config_word(pdev,
--
2.27.0

2022-11-04 19:15:44

by Jakub Kicinski

Subject: Re: [PATCH] net: libwx: Remove variable dev to simplify code

On Thu, 3 Nov 2022 15:19:56 +0800 Tang Bin wrote:
> In the function wx_get_pcie_msix_counts(), the variable dev
> is redundant, so remove it.

This patch doesn't make any difference.
Please consider not sending similar patches to netdev.