2022-11-06 14:08:18

by KaiLong Wang

Subject: [PATCH] EDAC: altera: Remove unnecessary print function dev_err()

Eliminate the follow coccicheck warning:

./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because
platform_get_irq() already prints an error
./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because
platform_get_irq() already prints an error

Signed-off-by: KaiLong Wang <[email protected]>
---
drivers/edac/altera_edac.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index e7e8e624a436..bd5b15ceb872 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -2150,7 +2150,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)

edac->sb_irq = platform_get_irq(pdev, 0);
if (edac->sb_irq < 0) {
- dev_err(&pdev->dev, "No SBERR IRQ resource\n");
return edac->sb_irq;
}

@@ -2185,7 +2184,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
#else
edac->db_irq = platform_get_irq(pdev, 1);
if (edac->db_irq < 0) {
- dev_err(&pdev->dev, "No DBERR IRQ resource\n");
return edac->db_irq;
}
irq_set_chained_handler_and_data(edac->db_irq,
--
2.25.1

2022-11-06 16:41:00

by Joe Perches

Subject: Re: [PATCH] EDAC: altera: Remove unnecessary print function dev_err()

On Sun, 2022-11-06 at 21:33 +0800, [email protected] wrote:
> Eliminate the follow coccicheck warning:
>
> ./drivers/edac/altera_edac.c:2153:2-9: line 2153 is redundant because
> platform_get_irq() already prints an error
> ./drivers/edac/altera_edac.c:2188:2-9: line 2188 is redundant because
> platform_get_irq() already prints an error
[]
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
[]
> @@ -2150,7 +2150,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>
> edac->sb_irq = platform_get_irq(pdev, 0);
> if (edac->sb_irq < 0) {
> - dev_err(&pdev->dev, "No SBERR IRQ resource\n");
> return edac->sb_irq;
> }

Should delete now unnecessary braces too

>
> @@ -2185,7 +2184,6 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
> #else
> edac->db_irq = platform_get_irq(pdev, 1);
> if (edac->db_irq < 0) {
> - dev_err(&pdev->dev, "No DBERR IRQ resource\n");
> return edac->db_irq;
> }
> irq_set_chained_handler_and_data(edac->db_irq,