2022-11-17 01:25:55

by Ian Rogers

Subject: [PATCH 0/6] Build output clean up

Reduce build spam from commands not prefixed with @. Make
install_headers targets distinguishable by adding in the library name
so:
INSTALL headers
becomes:
INSTALL libapi_headers

Ian Rogers (6):
tools lib api: clean up install_headers
tools lib bpf: Avoid install_headers make warning
tools lib symbol: clean up build output
tools lib perf: Make install_headers clearer
tools lib subcmd: Make install_headers clearer
tools lib traceevent: Make install_headers clearer

tools/lib/api/Makefile | 4 ++--
tools/lib/bpf/Makefile | 1 +
tools/lib/perf/Makefile | 2 +-
tools/lib/subcmd/Makefile | 2 +-
tools/lib/symbol/Makefile | 4 ++--
tools/lib/traceevent/Makefile | 4 ++--
6 files changed, 9 insertions(+), 8 deletions(-)

--
2.38.1.431.g37b22c650d-goog

2022-11-17 01:40:34

by Ian Rogers

Subject: [PATCH 4/6] tools lib perf: Make install_headers clearer

Add libperf to the name so that this install_headers build appears
different to similar targets in different libraries.

Signed-off-by: Ian Rogers <[email protected]>
---
tools/lib/perf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/perf/Makefile b/tools/lib/perf/Makefile
index 1badc0a04676..a90fb8c6bed4 100644
--- a/tools/lib/perf/Makefile
+++ b/tools/lib/perf/Makefile
@@ -188,7 +188,7 @@ install_lib: libs
cp -fpR $(LIBPERF_ALL) $(DESTDIR)$(libdir_SQ)

install_headers:
- $(call QUIET_INSTALL, headers) \
+ $(call QUIET_INSTALL, libperf_headers) \
$(call do_install,include/perf/bpf_perf.h,$(prefix)/include/perf,644); \
$(call do_install,include/perf/core.h,$(prefix)/include/perf,644); \
$(call do_install,include/perf/cpumap.h,$(prefix)/include/perf,644); \
--
2.38.1.431.g37b22c650d-goog

2022-11-17 15:43:43

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH 0/6] Build output clean up

Em Wed, Nov 16, 2022 at 04:43:50PM -0800, Ian Rogers escreveu:
> Reduce build spam from commands not prefixed with @. Make
> install_headers targets distinguishable by adding in the library name
> so:
> INSTALL headers
> becomes:
> INSTALL libapi_headers
>
> Ian Rogers (6):
> tools lib api: clean up install_headers
> tools lib bpf: Avoid install_headers make warning
> tools lib symbol: clean up build output
> tools lib perf: Make install_headers clearer
> tools lib subcmd: Make install_headers clearer
> tools lib traceevent: Make install_headers clearer

Andrii, are you ok with that? Can I carry this on my next (perf/core)
branch?

Testing it now.

- Arnaldo

> tools/lib/api/Makefile | 4 ++--
> tools/lib/bpf/Makefile | 1 +
> tools/lib/perf/Makefile | 2 +-
> tools/lib/subcmd/Makefile | 2 +-
> tools/lib/symbol/Makefile | 4 ++--
> tools/lib/traceevent/Makefile | 4 ++--
> 6 files changed, 9 insertions(+), 8 deletions(-)
>
> --
> 2.38.1.431.g37b22c650d-goog

--

- Arnaldo

2022-11-17 20:22:13

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH 0/6] Build output clean up

Em Thu, Nov 17, 2022 at 11:32:10AM -0800, Andrii Nakryiko escreveu:
> On Thu, Nov 17, 2022 at 7:40 AM Arnaldo Carvalho de Melo
> <[email protected]> wrote:
> >
> > Em Wed, Nov 16, 2022 at 04:43:50PM -0800, Ian Rogers escreveu:
> > > Reduce build spam from commands not prefixed with @. Make
> > > install_headers targets distinguishable by adding in the library name
> > > so:
> > > INSTALL headers
> > > becomes:
> > > INSTALL libapi_headers
> > >
> > > Ian Rogers (6):
> > > tools lib api: clean up install_headers
> > > tools lib bpf: Avoid install_headers make warning
> > > tools lib symbol: clean up build output
> > > tools lib perf: Make install_headers clearer
> > > tools lib subcmd: Make install_headers clearer
> > > tools lib traceevent: Make install_headers clearer
> >
> > Andrii, are you ok with that? Can I carry this on my next (perf/core)
> > branch?
>
> yep, lgtm. Please take it through your tree, in-kernel Makefile is not
> even synced into Github, so there is no downsides in terms of libbpf
> sync.
>
> Acked-by: Andrii Nakryiko <[email protected]>

Thanks, done.

- Arnaldo

2022-11-17 21:15:46

by Andrii Nakryiko

Subject: Re: [PATCH 0/6] Build output clean up

On Thu, Nov 17, 2022 at 7:40 AM Arnaldo Carvalho de Melo
<[email protected]> wrote:
>
> Em Wed, Nov 16, 2022 at 04:43:50PM -0800, Ian Rogers escreveu:
> > Reduce build spam from commands not prefixed with @. Make
> > install_headers targets distinguishable by adding in the library name
> > so:
> > INSTALL headers
> > becomes:
> > INSTALL libapi_headers
> >
> > Ian Rogers (6):
> > tools lib api: clean up install_headers
> > tools lib bpf: Avoid install_headers make warning
> > tools lib symbol: clean up build output
> > tools lib perf: Make install_headers clearer
> > tools lib subcmd: Make install_headers clearer
> > tools lib traceevent: Make install_headers clearer
>
> Andrii, are you ok with that? Can I carry this on my next (perf/core)
> branch?

yep, lgtm. Please take it through your tree, in-kernel Makefile is not
even synced into Github, so there is no downsides in terms of libbpf
sync.

Acked-by: Andrii Nakryiko <[email protected]>

>
> Testing it now.
>
> - Arnaldo
>
> > tools/lib/api/Makefile | 4 ++--
> > tools/lib/bpf/Makefile | 1 +
> > tools/lib/perf/Makefile | 2 +-
> > tools/lib/subcmd/Makefile | 2 +-
> > tools/lib/symbol/Makefile | 4 ++--
> > tools/lib/traceevent/Makefile | 4 ++--
> > 6 files changed, 9 insertions(+), 8 deletions(-)
> >
> > --
> > 2.38.1.431.g37b22c650d-goog
>
> --
>
> - Arnaldo