2023-01-21 23:36:06

by Masami Hiramatsu

Subject: [PATCH] selftests/ftrace: Fix bash specific "==" operator

From: Masami Hiramatsu (Google) <[email protected]>

Since commit a1d6cd88c897 ("selftests/ftrace: event_triggers: wait
longer for test_event_enable") introduced bash specific "=="
comparation operator, that test will fail when we run it on a
posix-shell. `checkbashisms` warned it as below.

possible bashism in ftrace/func_event_triggers.tc line 45 (should be 'b = a'):
if [ "$e" == $val ]; then

This replaces it with "=".

Fixes: a1d6cd88c897 ("selftests/ftrace: event_triggers: wait longer for test_event_enable")
Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
---
.../ftrace/test.d/ftrace/func_event_triggers.tc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
index 3eea2abf68f9..2ad7d4b501cc 100644
--- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
+++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
@@ -42,7 +42,7 @@ test_event_enabled() {

while [ $check_times -ne 0 ]; do
e=`cat $EVENT_ENABLE`
- if [ "$e" == $val ]; then
+ if [ "$e" = $val ]; then
return 0
fi
sleep $SLEEP_TIME

2023-01-25 00:16:53

by Steven Rostedt

Subject: Re: [PATCH] selftests/ftrace: Fix bash specific "==" operator

On Sun, 22 Jan 2023 08:32:50 +0900
"Masami Hiramatsu (Google)" <[email protected]> wrote:

> From: Masami Hiramatsu (Google) <[email protected]>
>
> Since commit a1d6cd88c897 ("selftests/ftrace: event_triggers: wait
> longer for test_event_enable") introduced bash specific "=="
> comparation operator, that test will fail when we run it on a
> posix-shell. `checkbashisms` warned it as below.
>
> possible bashism in ftrace/func_event_triggers.tc line 45 (should be 'b = a'):
> if [ "$e" == $val ]; then
>
> This replaces it with "=".
>
> Fixes: a1d6cd88c897 ("selftests/ftrace: event_triggers: wait longer for test_event_enable")
> Signed-off-by: Masami Hiramatsu (Google) <[email protected]>

Reviewed-by: Steven Rostedt (Google) <[email protected]>

Shuah,

Care to pull this through your tree?

-- Steve

> ---
> .../ftrace/test.d/ftrace/func_event_triggers.tc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> index 3eea2abf68f9..2ad7d4b501cc 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc
> @@ -42,7 +42,7 @@ test_event_enabled() {
>
> while [ $check_times -ne 0 ]; do
> e=`cat $EVENT_ENABLE`
> - if [ "$e" == $val ]; then
> + if [ "$e" = $val ]; then
> return 0
> fi
> sleep $SLEEP_TIME

2023-02-03 16:57:31

by Shuah Khan

Subject: Re: [PATCH] selftests/ftrace: Fix bash specific "==" operator

On 1/24/23 17:16, Steven Rostedt wrote:
> On Sun, 22 Jan 2023 08:32:50 +0900
> "Masami Hiramatsu (Google)" <[email protected]> wrote:
>
>> From: Masami Hiramatsu (Google) <[email protected]>
>>
>> Since commit a1d6cd88c897 ("selftests/ftrace: event_triggers: wait
>> longer for test_event_enable") introduced bash specific "=="
>> comparation operator, that test will fail when we run it on a
>> posix-shell. `checkbashisms` warned it as below.
>>
>> possible bashism in ftrace/func_event_triggers.tc line 45 (should be 'b = a'):
>> if [ "$e" == $val ]; then
>>
>> This replaces it with "=".
>>
>> Fixes: a1d6cd88c897 ("selftests/ftrace: event_triggers: wait longer for test_event_enable")
>> Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
>
> Reviewed-by: Steven Rostedt (Google) <[email protected]>
>
> Shuah,
>
> Care to pull this through your tree?
>

Yes. Will appear shortly in linux-kselftest next.

thanks,
-- Shuah