2023-03-14 02:41:29

by Li zeming

Subject: [PATCH] mm: mempool: Optimize the mempool_create_node function

The pool pointer variable gets the kzalloc_node function return value
directly at definition time, which should be more concise.

Signed-off-by: Li zeming <[email protected]>
---
mm/mempool.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mm/mempool.c b/mm/mempool.c
index 734bcf5afbb7..9a4db6efc9ab 100644
--- a/mm/mempool.c
+++ b/mm/mempool.c
@@ -267,9 +267,7 @@ mempool_t *mempool_create_node(int min_nr, mempool_alloc_t *alloc_fn,
mempool_free_t *free_fn, void *pool_data,
gfp_t gfp_mask, int node_id)
{
- mempool_t *pool;
-
- pool = kzalloc_node(sizeof(*pool), gfp_mask, node_id);
+ mempool_t *pool = kzalloc_node(sizeof(*pool), gfp_mask, node_id);
if (!pool)
return NULL;

--
2.18.2

2023-03-15 17:53:24

by Florian Fainelli

Subject: Re: [PATCH] mm: mempool: Optimize the mempool_create_node function

On 3/15/23 12:12, Li zeming wrote:
> The pool pointer variable gets the kzalloc_node function return value
> directly at definition time, which should be more concise.
>
> Signed-off-by: Li zeming <[email protected]>

This looks pretty useless as a change, the generated code is going to be
the same before/after, it is also not more readable, and it is
definitively not an optimization in the sense that optimization should
be used as meaning: the code is more efficient after that change.
--
Florian