2023-03-22 08:27:59

by ye.xingchen

Subject: [PATCH] drm: bridge: simple-bridge: Use dev_err_probe()

From: Ye Xingchen <[email protected]>

Replace the open-code with dev_err_probe() to simplify the code.

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/gpu/drm/bridge/simple-bridge.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
index 5ede3e111096..d85d9ee463b8 100644
--- a/drivers/gpu/drm/bridge/simple-bridge.c
+++ b/drivers/gpu/drm/bridge/simple-bridge.c
@@ -202,11 +202,9 @@ static int simple_bridge_probe(struct platform_device *pdev)

sbridge->enable = devm_gpiod_get_optional(&pdev->dev, "enable",
GPIOD_OUT_LOW);
- if (IS_ERR(sbridge->enable)) {
- if (PTR_ERR(sbridge->enable) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Unable to retrieve enable GPIO\n");
- return PTR_ERR(sbridge->enable);
- }
+ if (IS_ERR(sbridge->enable))
+ return dev_err_probe(&pdev->dev, PTR_ERR(sbridge->enable),
+ "Unable to retrieve enable GPIO\n");

/* Register the bridge. */
sbridge->bridge.funcs = &simple_bridge_bridge_funcs;
--
2.25.1

2023-03-22 09:09:17

by Laurent Pinchart

Subject: Re: [PATCH] drm: bridge: simple-bridge: Use dev_err_probe()

Hi Ye,

Thank you for the patch.

On Wed, Mar 22, 2023 at 04:22:51PM +0800, [email protected] wrote:
> From: Ye Xingchen <[email protected]>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/simple-bridge.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
> index 5ede3e111096..d85d9ee463b8 100644
> --- a/drivers/gpu/drm/bridge/simple-bridge.c
> +++ b/drivers/gpu/drm/bridge/simple-bridge.c
> @@ -202,11 +202,9 @@ static int simple_bridge_probe(struct platform_device *pdev)
>
> sbridge->enable = devm_gpiod_get_optional(&pdev->dev, "enable",
> GPIOD_OUT_LOW);
> - if (IS_ERR(sbridge->enable)) {
> - if (PTR_ERR(sbridge->enable) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Unable to retrieve enable GPIO\n");
> - return PTR_ERR(sbridge->enable);
> - }
> + if (IS_ERR(sbridge->enable))
> + return dev_err_probe(&pdev->dev, PTR_ERR(sbridge->enable),
> + "Unable to retrieve enable GPIO\n");
>
> /* Register the bridge. */
> sbridge->bridge.funcs = &simple_bridge_bridge_funcs;

--
Regards,

Laurent Pinchart

2023-03-22 10:53:56

by Neil Armstrong

Subject: Re: [PATCH] drm: bridge: simple-bridge: Use dev_err_probe()

Hi,

On Wed, 22 Mar 2023 16:22:51 +0800, [email protected] wrote:
> Replace the open-code with dev_err_probe() to simplify the code.
>
>

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm: bridge: simple-bridge: Use dev_err_probe()
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=db8496d0b50519540e1ee50f7e209b3a536ed671

--
Neil