2023-06-21 17:32:48

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd: sm501: prefer unsigned int over unsigned

On Tue, 13 Jun 2023, [email protected] wrote:

>
> Fix the following coccicheck warning:
>
> drivers/mfd/sm501.c:887: Prefer 'unsigned int' to bare use of 'unsigned'.
>
> Signed-off-by: Mindtong Bao <[email protected]>
> ---
> drivers/mfd/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This patch did not make it to the upstream mailing list (LKML).

https://lore.kernel.org/all/?q=%22mfd%3A+sm501%3A+prefer+unsigned+int+over+unsigned%22

I cannot take it unless it shows up there first.

Please debug this and resend.

> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index 28027982cf69..f08ad7249dc5 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -884,7 +884,7 @@ static inline struct sm501_devdata
> *sm501_gpio_to_dev(struct sm501_gpio *gpio)
> return container_of(gpio, struct sm501_devdata, gpio);
> }
>
> -static int sm501_gpio_get(struct gpio_chip *chip, unsigned offset)
> +static int sm501_gpio_get(struct gpio_chip *chip, unsigned int offset)
>
> {
> struct sm501_gpio_chip *smgpio = gpiochip_get_data(chip);

--
Lee Jones [李琼斯]