2023-06-23 05:54:26

by Sidhartha Kumar

Subject: [PATCH] mm/hugetlb: remove hugetlb_set_page_subpool()

All users have been converted to hugetlb_set_folio_subpool() so we can
safely remove this function.

Signed-off-by: Sidhartha Kumar <[email protected]>
---
include/linux/hugetlb.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index beb7c63d28716..d14676b6d144f 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -761,11 +761,6 @@ static inline void hugetlb_set_folio_subpool(struct folio *folio,
folio->_hugetlb_subpool = subpool;
}

-static inline void hugetlb_set_page_subpool(struct page *hpage,
- struct hugepage_subpool *subpool)
-{
- hugetlb_set_folio_subpool(page_folio(hpage), subpool);
-}

static inline struct hstate *hstate_file(struct file *f)
{
--
2.41.0

2023-06-27 10:14:49

by David Hildenbrand

Subject: Re: [PATCH] mm/hugetlb: remove hugetlb_set_page_subpool()

On 23.06.23 07:46, Sidhartha Kumar wrote:
> All users have been converted to hugetlb_set_folio_subpool() so we can
> safely remove this function.
>
> Signed-off-by: Sidhartha Kumar <[email protected]>
> ---
> include/linux/hugetlb.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index beb7c63d28716..d14676b6d144f 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -761,11 +761,6 @@ static inline void hugetlb_set_folio_subpool(struct folio *folio,
> folio->_hugetlb_subpool = subpool;
> }
>
> -static inline void hugetlb_set_page_subpool(struct page *hpage,
> - struct hugepage_subpool *subpool)
> -{
> - hugetlb_set_folio_subpool(page_folio(hpage), subpool);
> -}
>
> static inline struct hstate *hstate_file(struct file *f)
> {

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb