2023-06-23 06:22:05

by Sidhartha Kumar

Subject: [PATCH v2] mm/hugetlb: remove hugetlb_set_page_subpool()

All users have been converted to hugetlb_set_folio_subpool() so we can
safely remove this function.

Signed-off-by: Sidhartha Kumar <[email protected]>
---
v1 -> v2:
get rid of extra newline

include/linux/hugetlb.h | 6 ------
1 file changed, 6 deletions(-)

diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index beb7c63d28716..ca3c8e10f24a0 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -761,12 +761,6 @@ static inline void hugetlb_set_folio_subpool(struct folio *folio,
folio->_hugetlb_subpool = subpool;
}

-static inline void hugetlb_set_page_subpool(struct page *hpage,
- struct hugepage_subpool *subpool)
-{
- hugetlb_set_folio_subpool(page_folio(hpage), subpool);
-}
-
static inline struct hstate *hstate_file(struct file *f)
{
return hstate_inode(file_inode(f));
--
2.41.0

2023-07-03 18:44:55

by Mike Kravetz

Subject: Re: [PATCH v2] mm/hugetlb: remove hugetlb_set_page_subpool()

On 06/22/23 22:49, Sidhartha Kumar wrote:
> All users have been converted to hugetlb_set_folio_subpool() so we can
> safely remove this function.
>
> Signed-off-by: Sidhartha Kumar <[email protected]>
> ---
> v1 -> v2:
> get rid of extra newline
>
> include/linux/hugetlb.h | 6 ------
> 1 file changed, 6 deletions(-)

Thanks,

Reviewed-by: Mike Kravetz <[email protected]>

--
Mike Kravetz

>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index beb7c63d28716..ca3c8e10f24a0 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -761,12 +761,6 @@ static inline void hugetlb_set_folio_subpool(struct folio *folio,
> folio->_hugetlb_subpool = subpool;
> }
>
> -static inline void hugetlb_set_page_subpool(struct page *hpage,
> - struct hugepage_subpool *subpool)
> -{
> - hugetlb_set_folio_subpool(page_folio(hpage), subpool);
> -}
> -
> static inline struct hstate *hstate_file(struct file *f)
> {
> return hstate_inode(file_inode(f));
> --
> 2.41.0
>