2023-08-07 09:49:42

by Hsin-Te Yuan

[permalink] [raw]
Subject: [PATCH] arm64: dts: mt8195: change watchdog reset boot flow

The external output reset signal was originally disabled and sent from
firmware. However, an unfixed bug in the firmware prevents the signal
from being sent, causing the device to fail to boot. To fix this, enable
external output reset signal to allow the device to reboot normally.

Signed-off-by: Hsin-Te Yuan <[email protected]>
---

arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
index 37a3e9de90ff7..5dc4214e1840b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
@@ -1147,6 +1147,10 @@ &uart0 {
status = "okay";
};

+&watchdog {
+ /delete-property/ mediatek,disable-extrst;
+};
+
&xhci0 {
status = "okay";

--
2.41.0.585.gd2178a4bd4-goog



2023-08-07 11:39:48

by Eugen Hristev

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: mt8195: change watchdog reset boot flow

Hello Hsin-Te,

On 8/7/23 11:58, Hsin-Te Yuan wrote:
> The external output reset signal was originally disabled and sent from
> firmware. However, an unfixed bug in the firmware prevents the signal
> from being sent, causing the device to fail to boot. To fix this, enable
> external output reset signal to allow the device to reboot normally.
>
> Signed-off-by: Hsin-Te Yuan <[email protected]>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> index 37a3e9de90ff7..5dc4214e1840b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> @@ -1147,6 +1147,10 @@ &uart0 {
> status = "okay";
> };
>
> +&watchdog {
> + /delete-property/ mediatek,disable-extrst;
> +};
> +

Does this affect only the mt8195-cherry or all mt8195 boards ?

Judging by this commit , I think only mt8195-cherry, but your commit
message somehow suggests otherwise.

Eugen

> &xhci0 {
> status = "okay";
>