2023-08-10 12:41:33

by Arnd Bergmann

Subject: [PATCH 2/2] ethernet: atarilance: mark init function static

From: Arnd Bergmann <[email protected]>

The init function is only referenced locally, so it should be static to
avoid this warning:

drivers/net/ethernet/amd/atarilance.c:370:28: error: no previous prototype for 'atarilance_probe' [-Werror=missing-prototypes]

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/net/ethernet/amd/atarilance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/atarilance.c b/drivers/net/ethernet/amd/atarilance.c
index ec704222925d8..751454d305c64 100644
--- a/drivers/net/ethernet/amd/atarilance.c
+++ b/drivers/net/ethernet/amd/atarilance.c
@@ -367,7 +367,7 @@ static void *slow_memcpy( void *dst, const void *src, size_t len )
}


-struct net_device * __init atarilance_probe(void)
+static struct net_device * __init atarilance_probe(void)
{
int i;
static int found;
--
2.39.2

2023-08-10 13:42:43

by Yang Yingliang

Subject: Re: [PATCH 2/2] ethernet: atarilance: mark init function static

On 2023/8/10 20:25, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The init function is only referenced locally, so it should be static to
> avoid this warning:
>
> drivers/net/ethernet/amd/atarilance.c:370:28: error: no previous prototype for 'atarilance_probe' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <[email protected]>
Reviewed-by: Yang Yingliang <[email protected]>