2023-09-16 07:16:44

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH] firmware: qcom: qseecom: Add missing AUXILIARY_BUS dependency

The newly introduced QSEECOM driver fail to link if the system is built
without CONFIG_AUXILIARY_BUS, make sure it is selected.

Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface")
Reported-by: Randy Dunlap <[email protected]>
Closes: https://lore.kernel.org/r/9f156fa6-e5aa-4cb2-ab2b-b67fd8fc4840%40infradead.org
Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/firmware/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index a94202229a71..8c608be30060 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -229,6 +229,7 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT
config QCOM_QSEECOM
bool "Qualcomm QSEECOM interface driver"
depends on QCOM_SCM=y
+ select AUXILIARY_BUS
help
Various Qualcomm SoCs have a Secure Execution Environment (SEE) running
in the Trust Zone. This module provides an interface to that via the

---
base-commit: dfa449a58323de195773cf928d99db4130702bf7
change-id: 20230915-qseecom-auxiliary-fix-1574abe3bc98

Best regards,
--
Bjorn Andersson <[email protected]>


2023-09-18 06:03:20

by Maximilian Luz

[permalink] [raw]
Subject: Re: [PATCH] firmware: qcom: qseecom: Add missing AUXILIARY_BUS dependency

On 9/16/23 00:50, Bjorn Andersson wrote:
> The newly introduced QSEECOM driver fail to link if the system is built
> without CONFIG_AUXILIARY_BUS, make sure it is selected.
>
> Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface")
> Reported-by: Randy Dunlap <[email protected]>
> Closes: https://lore.kernel.org/r/9f156fa6-e5aa-4cb2-ab2b-b67fd8fc4840%40infradead.org
> Signed-off-by: Bjorn Andersson <[email protected]>

Thanks for the quick fix!

Reviewed-by: Maximilian Luz <[email protected]>

> ---
> drivers/firmware/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index a94202229a71..8c608be30060 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -229,6 +229,7 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT
> config QCOM_QSEECOM
> bool "Qualcomm QSEECOM interface driver"
> depends on QCOM_SCM=y
> + select AUXILIARY_BUS
> help
> Various Qualcomm SoCs have a Secure Execution Environment (SEE) running
> in the Trust Zone. This module provides an interface to that via the
>
> ---
> base-commit: dfa449a58323de195773cf928d99db4130702bf7
> change-id: 20230915-qseecom-auxiliary-fix-1574abe3bc98
>
> Best regards,

2023-09-19 23:04:49

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] firmware: qcom: qseecom: Add missing AUXILIARY_BUS dependency


On Fri, 15 Sep 2023 15:50:14 -0700, Bjorn Andersson wrote:
> The newly introduced QSEECOM driver fail to link if the system is built
> without CONFIG_AUXILIARY_BUS, make sure it is selected.
>
>

Applied, thanks!

[1/1] firmware: qcom: qseecom: Add missing AUXILIARY_BUS dependency
commit: d74612b6da61aeb32e81bcf762b8be4e3c41bda5

Best regards,
--
Bjorn Andersson <[email protected]>