2023-09-22 02:03:40

by Wang Jinchao

Subject: [PATCH] memory-hotplug.rst: fix wrong /sys/device/ path

Actually, it should be /sys/devices/

Signed-off-by: Wang Jinchao <[email protected]>
---
Documentation/admin-guide/mm/memory-hotplug.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst
index cfe034cf1e87..01595965734a 100644
--- a/Documentation/admin-guide/mm/memory-hotplug.rst
+++ b/Documentation/admin-guide/mm/memory-hotplug.rst
@@ -250,15 +250,15 @@ Observing the State of Memory Blocks
The state (online/offline/going-offline) of a memory block can be observed
either via::

- % cat /sys/device/system/memory/memoryXXX/state
+ % cat /sys/devices/system/memory/memoryXXX/state

Or alternatively (1/0) via::

- % cat /sys/device/system/memory/memoryXXX/online
+ % cat /sys/devices/system/memory/memoryXXX/online

For an online memory block, the managing zone can be observed via::

- % cat /sys/device/system/memory/memoryXXX/valid_zones
+ % cat /sys/devices/system/memory/memoryXXX/valid_zones

Configuring Memory Hot(Un)Plug
==============================
@@ -326,7 +326,7 @@ however, a memory block might span memory holes. A memory block spanning memory
holes cannot be offlined.

For example, assume 1 GiB memory block size. A device for a memory starting at
-0x100000000 is ``/sys/device/system/memory/memory4``::
+0x100000000 is ``/sys/devices/system/memory/memory4``::

(0x100000000 / 1Gib = 4)

--
2.40.0

2023-09-22 11:58:25

by David Hildenbrand

Subject: Re: [PATCH] memory-hotplug.rst: fix wrong /sys/device/ path

On 22.09.23 04:00, Wang Jinchao wrote:
> Actually, it should be /sys/devices/
>
> Signed-off-by: Wang Jinchao <[email protected]>
> ---
> Documentation/admin-guide/mm/memory-hotplug.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst
> index cfe034cf1e87..01595965734a 100644
> --- a/Documentation/admin-guide/mm/memory-hotplug.rst
> +++ b/Documentation/admin-guide/mm/memory-hotplug.rst
> @@ -250,15 +250,15 @@ Observing the State of Memory Blocks
> The state (online/offline/going-offline) of a memory block can be observed
> either via::
>
> - % cat /sys/device/system/memory/memoryXXX/state
> + % cat /sys/devices/system/memory/memoryXXX/state
>
> Or alternatively (1/0) via::
>
> - % cat /sys/device/system/memory/memoryXXX/online
> + % cat /sys/devices/system/memory/memoryXXX/online
>
> For an online memory block, the managing zone can be observed via::
>
> - % cat /sys/device/system/memory/memoryXXX/valid_zones
> + % cat /sys/devices/system/memory/memoryXXX/valid_zones
>
> Configuring Memory Hot(Un)Plug
> ==============================
> @@ -326,7 +326,7 @@ however, a memory block might span memory holes. A memory block spanning memory
> holes cannot be offlined.
>
> For example, assume 1 GiB memory block size. A device for a memory starting at
> -0x100000000 is ``/sys/device/system/memory/memory4``::
> +0x100000000 is ``/sys/devices/system/memory/memory4``::
>
> (0x100000000 / 1Gib = 4)
>

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb

2023-09-22 15:44:23

by Jonathan Corbet

Subject: Re: [PATCH] memory-hotplug.rst: fix wrong /sys/device/ path

Wang Jinchao <[email protected]> writes:

> Actually, it should be /sys/devices/
>
> Signed-off-by: Wang Jinchao <[email protected]>
> ---
> Documentation/admin-guide/mm/memory-hotplug.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

jon