2023-10-03 02:36:13

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the execve tree

---

Hi all,

After merging the execve tree, today's linux-next build (x86_64
allmodconfig) failed like this:

fs/binfmt_elf.c: In function 'load_elf_library':
fs/binfmt_elf.c:1323:37: error: unused variable 'len' [-Werror=unused-variable]
1323 | unsigned long elf_bss, bss, len;
| ^~~
fs/binfmt_elf.c:1323:32: error: unused variable 'bss' [-Werror=unused-variable]
1323 | unsigned long elf_bss, bss, len;
| ^~~
fs/binfmt_elf.c:1323:23: error: unused variable 'elf_bss' [-Werror=unused-variable]
1323 | unsigned long elf_bss, bss, len;
| ^~~~~~~
cc1: all warnings being treated as errors

Caused by commit

f2a1e5fab9ae ("binfmt_elf: Use elf_load() for library")

I have used the execve tree from next-20230929 for today.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2023-10-04 02:51:14

by Kees Cook

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the execve tree

---

On Tue, Oct 03, 2023 at 01:35:22PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the execve tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> fs/binfmt_elf.c: In function 'load_elf_library':
> fs/binfmt_elf.c:1323:37: error: unused variable 'len' [-Werror=unused-variable]
> 1323 | unsigned long elf_bss, bss, len;
> | ^~~
> fs/binfmt_elf.c:1323:32: error: unused variable 'bss' [-Werror=unused-variable]
> 1323 | unsigned long elf_bss, bss, len;
> | ^~~
> fs/binfmt_elf.c:1323:23: error: unused variable 'elf_bss' [-Werror=unused-variable]
> 1323 | unsigned long elf_bss, bss, len;
> | ^~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> f2a1e5fab9ae ("binfmt_elf: Use elf_load() for library")
>
> I have used the execve tree from next-20230929 for today.

Whoops! Fixed now. Thanks. :)

--
Kees Cook