2023-10-17 07:38:07

by Jai Luthra

Subject: [PATCH] media: platform: cadence: select MIPI_DPHY dependency

The driver uses MIPI DPHY helper routines from the PHY core. Make sure
we select the relevant config for compilation.

Fixes: a91d06f46bf7 ("media: cadence: csi2rx: Configure DPHY using link freq")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Jai Luthra <[email protected]>
---
drivers/media/platform/cadence/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/cadence/Kconfig b/drivers/media/platform/cadence/Kconfig
index 480325d053de..317bd9e2e728 100644
--- a/drivers/media/platform/cadence/Kconfig
+++ b/drivers/media/platform/cadence/Kconfig
@@ -8,6 +8,7 @@ config VIDEO_CADENCE_CSI2RX
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
+ select GENERIC_PHY_MIPI_DPHY
help
Support for the Cadence MIPI CSI2 Receiver controller.


---
base-commit: 94e27fbeca27d8c772fc2bc807730aaee5886055
change-id: 20231017-cdns_phy_config-a9f8aaa02f5b

Best regards,
--
Jai Luthra <[email protected]>

2023-10-17 07:57:40

by Sakari Ailus

Subject: Re: [PATCH] media: platform: cadence: select MIPI_DPHY dependency

Hi Jai,

Thanks for the patch.

On Tue, Oct 17, 2023 at 01:07:24PM +0530, Jai Luthra wrote:
> The driver uses MIPI DPHY helper routines from the PHY core. Make sure
> we select the relevant config for compilation.
>
> Fixes: a91d06f46bf7 ("media: cadence: csi2rx: Configure DPHY using link freq")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Jai Luthra <[email protected]>
> ---
> drivers/media/platform/cadence/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/cadence/Kconfig b/drivers/media/platform/cadence/Kconfig
> index 480325d053de..317bd9e2e728 100644
> --- a/drivers/media/platform/cadence/Kconfig
> +++ b/drivers/media/platform/cadence/Kconfig
> @@ -8,6 +8,7 @@ config VIDEO_CADENCE_CSI2RX
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> + select GENERIC_PHY_MIPI_DPHY

Selecting GENERIC_PHY_MIPI_DPHY isn't enough as it depends on GENERIC_PHY.
I'll add the missing select line while applying this.

> help
> Support for the Cadence MIPI CSI2 Receiver controller.
>
>

--
Regards,

Sakari Ailus