2024-01-31 07:13:56

by Dan Carpenter

Subject: [PATCH] wifi: rtl8xxxu: fix error messages

The first parameter of WARN_ONCE() is a condition so this code will end
up printing the function name instead of the proper message.

Fixes: 3ff7a05996f9 ("wifi: rtl8xxxu: support setting bssid register for multiple interfaces")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 3b954c2fe448..bd6fd3120562 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -3593,7 +3593,7 @@ static int rtl8xxxu_set_mac(struct rtl8xxxu_priv *priv, int port_num)
reg = REG_MACID1;
break;
default:
- WARN_ONCE("%s: invalid port_num\n", __func__);
+ WARN_ONCE(1, "%s: invalid port_num\n", __func__);
return -EINVAL;
}

@@ -3618,7 +3618,7 @@ static int rtl8xxxu_set_bssid(struct rtl8xxxu_priv *priv, const u8 *bssid, int p
reg = REG_BSSID1;
break;
default:
- WARN_ONCE("%s: invalid port_num\n", __func__);
+ WARN_ONCE(1, "%s: invalid port_num\n", __func__);
return -EINVAL;
}

--
2.43.0

2024-02-01 10:21:32

by Kalle Valo

Subject: Re: [PATCH] wifi: rtl8xxxu: fix error messages

Dan Carpenter <[email protected]> wrote:

> The first parameter of WARN_ONCE() is a condition so this code will end
> up printing the function name instead of the proper message.
>
> Fixes: 3ff7a05996f9 ("wifi: rtl8xxxu: support setting bssid register for multiple interfaces")
> Signed-off-by: Dan Carpenter <[email protected]>
> Reviewed-by: Ping-Ke Shih <[email protected]>

Patch applied to wireless-next.git, thanks.

17903a283593 wifi: rtl8xxxu: fix error messages

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches