2017-11-06 16:22:48

by Yang Shi

[permalink] [raw]
Subject: Re: [PATCH] mm: filemap: remove include of hardirq.h



On 11/4/17 6:47 AM, Matthew Wilcox wrote:
> On Sat, Nov 04, 2017 at 02:47:48AM +0800, Yang Shi wrote:
>> in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
>> doesn't use in_atomic() directly at all, so it sounds unnecessary to
>> include hardirq.h.
>> With removing hardirq.h, around 32 bytes can be saved for x86_64 bzImage
>> with allnoconfig.
>
> Wait, what? How would including an unused header file increase the size
> of the final image?

Sorry for the wrong message, I double checked again with building kernel
a couple of times then comparing the size, there is no change. Will
remove this from the commit log.

Yang

>

From 1583143488457993753@xxx Sat Nov 04 13:48:04 +0000 2017
X-GM-THRID: 1583071819350852518
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread