2017-11-02 15:12:38

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] block: fix CDROM dependency on BLK_DEV

On 11/02/2017 09:01 AM, Bart Van Assche wrote:
> On Thu, 2017-11-02 at 08:27 -0600, Jens Axboe wrote:
>> On 11/02/2017 05:19 AM, Arnd Bergmann wrote:
>>> After the cdrom cleanup, I get randconfig warnings for some configurations:
>>>
>>> warning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV)
>>>
>>> This adds an explicit BLK_DEV dependency for both drivers. The other
>>> drivers that select 'CDROM' already have this and don't need a change.
>>
>> Thanks Arnd, applied.
>
> Hello Jens,
>
> Can you wait at least 24 hours after a patch has been posted before applying it
> such those who want to post review comments have a chance to do that?

I generally at least do that, unless they are trivial...


--
Jens Axboe


From 1582967317449076158@xxx Thu Nov 02 15:07:54 +0000 2017
X-GM-THRID: 1582953154006260596
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread