2024-04-04 15:55:23

by Muhammad Usama Anjum

Subject: [PATCH] kselftest: Add missing signature to the comments

The comment on top of the file is used by many developers to glance over
all the available functions. Add the recently added ksft_perror() to it.

Signed-off-by: Muhammad Usama Anjum <[email protected]>
---
tools/testing/selftests/kselftest.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
index 7d650a06ca359..159bf8e314fa3 100644
--- a/tools/testing/selftests/kselftest.h
+++ b/tools/testing/selftests/kselftest.h
@@ -16,6 +16,7 @@
* For each test, report any progress, debugging, etc with:
*
* ksft_print_msg(fmt, ...);
+ * ksft_perror(msg);
*
* and finally report the pass/fail/skip/xfail state of the test with one of:
*
--
2.39.2

2024-04-04 17:06:33

by Shuah Khan

Subject: Re: [PATCH] kselftest: Add missing signature to the comments

On 4/4/24 09:55, Muhammad Usama Anjum wrote:
> The comment on top of the file is used by many developers to glance over
> all the available functions. Add the recently added ksft_perror() to it.
>
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---
> tools/testing/selftests/kselftest.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index 7d650a06ca359..159bf8e314fa3 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -16,6 +16,7 @@
> * For each test, report any progress, debugging, etc with:
> *
> * ksft_print_msg(fmt, ...);
> + * ksft_perror(msg);
> *
> * and finally report the pass/fail/skip/xfail state of the test with one of:
> *

Thank you. Applied to linux-kselftest next for Linux 6.10-rc1

thanks,
-- Shuah