2024-05-23 21:08:15

by Dr. David Alan Gilbert

Subject: [PATCH] dm cache metadata: remove unused struct 'thunk'

From: "Dr. David Alan Gilbert" <[email protected]>

'thunk' has been unused since
commit f177940a8091 ("dm cache metadata: switch to using the new
cursor api for loading metadata").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/md/dm-cache-metadata.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
index 96751cd3d181..0ad9dc1824fa 100644
--- a/drivers/md/dm-cache-metadata.c
+++ b/drivers/md/dm-cache-metadata.c
@@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
return r;
}

-struct thunk {
- load_mapping_fn fn;
- void *context;
-
- struct dm_cache_metadata *cmd;
- bool respect_dirty_flags;
- bool hints_valid;
-};
-
static bool policy_unchanged(struct dm_cache_metadata *cmd,
struct dm_cache_policy *policy)
{
--
2.45.1

2024-06-08 20:49:31

by Dr. David Alan Gilbert

Subject: Re: [PATCH] dm cache metadata: remove unused struct 'thunk'

* [email protected] ([email protected]) wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'thunk' has been unused since
> commit f177940a8091 ("dm cache metadata: switch to using the new
> cursor api for loading metadata").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Ping

> ---
> drivers/md/dm-cache-metadata.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
> index 96751cd3d181..0ad9dc1824fa 100644
> --- a/drivers/md/dm-cache-metadata.c
> +++ b/drivers/md/dm-cache-metadata.c
> @@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
> return r;
> }
>
> -struct thunk {
> - load_mapping_fn fn;
> - void *context;
> -
> - struct dm_cache_metadata *cmd;
> - bool respect_dirty_flags;
> - bool hints_valid;
> -};
> -
> static bool policy_unchanged(struct dm_cache_metadata *cmd,
> struct dm_cache_policy *policy)
> {
> --
> 2.45.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/