2024-05-31 10:28:25

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] serial: sc16is7xx: set driver name

On Fri, May 31, 2024 at 12:19:59PM +0200, Daniel Mack wrote:
> Set the drv_name field of the driver struct so that the tty core
> registers a procfs entry for it. This is useful for debugging.
>
> Signed-off-by: Daniel Mack <[email protected]>
> ---
> drivers/tty/serial/sc16is7xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index bf0065d1c8e9..308edbacda7b 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -351,6 +351,7 @@ static struct uart_driver sc16is7xx_uart = {
> .owner = THIS_MODULE,
> .driver_name = SC16IS7XX_NAME,
> .dev_name = "ttySC",
> + .driver_name = SC16IS7XX_NAME,

Are you sure this patch is correct? Look 2 lines up :)



2024-05-31 15:16:53

by Daniel Mack

[permalink] [raw]
Subject: Re: [PATCH] serial: sc16is7xx: set driver name

On 5/31/24 12:27, Greg KH wrote:
> On Fri, May 31, 2024 at 12:19:59PM +0200, Daniel Mack wrote:
>> Set the drv_name field of the driver struct so that the tty core
>> registers a procfs entry for it. This is useful for debugging.
>>
>> Signed-off-by: Daniel Mack <[email protected]>
>> ---
>> drivers/tty/serial/sc16is7xx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
>> index bf0065d1c8e9..308edbacda7b 100644
>> --- a/drivers/tty/serial/sc16is7xx.c
>> +++ b/drivers/tty/serial/sc16is7xx.c
>> @@ -351,6 +351,7 @@ static struct uart_driver sc16is7xx_uart = {
>> .owner = THIS_MODULE,
>> .driver_name = SC16IS7XX_NAME,
>> .dev_name = "ttySC",
>> + .driver_name = SC16IS7XX_NAME,
>
> Are you sure this patch is correct? Look 2 lines up :)
>

Oh, Hugo did that already. Sorry for the noise.


Daniel