2024-06-06 13:01:22

by Ricardo Ribalda

Subject: [PATCH] media: c8sectpfe: Add missing parameter names

clang 19 complains about the missing parameter name. Let's add it.

drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h:19:62: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: e22b4973ee20 ("media: c8sectpfe: Do not depend on DEBUG_FS")
Signed-off-by: Ricardo Ribalda <[email protected]>
---
drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
index 8e1bfd860524..3fe177b59b16 100644
--- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
+++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
@@ -16,8 +16,8 @@
void c8sectpfe_debugfs_init(struct c8sectpfei *);
void c8sectpfe_debugfs_exit(struct c8sectpfei *);
#else
-static inline void c8sectpfe_debugfs_init(struct c8sectpfei *) {};
-static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *) {};
+static inline void c8sectpfe_debugfs_init(struct c8sectpfei *fei) {};
+static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *fei) {};
#endif

#endif /* __C8SECTPFE_DEBUG_H */

---
base-commit: 1aea3d1d4a21e3e7895663b848ffae79ee82e065
change-id: 20240606-c8sectpfe-5f00b9867f36

Best regards,
--
Ricardo Ribalda <[email protected]>

2024-06-07 16:37:47

by Nathan Chancellor

Subject: Re: [PATCH] media: c8sectpfe: Add missing parameter names

On Thu, Jun 06, 2024 at 01:01:07PM +0000, Ricardo Ribalda wrote:
> clang 19 complains about the missing parameter name. Let's add it.
>
> drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h:19:62: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: e22b4973ee20 ("media: c8sectpfe: Do not depend on DEBUG_FS")
> Signed-off-by: Ricardo Ribalda <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
> drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> index 8e1bfd860524..3fe177b59b16 100644
> --- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> +++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> @@ -16,8 +16,8 @@
> void c8sectpfe_debugfs_init(struct c8sectpfei *);
> void c8sectpfe_debugfs_exit(struct c8sectpfei *);
> #else
> -static inline void c8sectpfe_debugfs_init(struct c8sectpfei *) {};
> -static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *) {};
> +static inline void c8sectpfe_debugfs_init(struct c8sectpfei *fei) {};
> +static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *fei) {};
> #endif
>
> #endif /* __C8SECTPFE_DEBUG_H */
>
> ---
> base-commit: 1aea3d1d4a21e3e7895663b848ffae79ee82e065
> change-id: 20240606-c8sectpfe-5f00b9867f36
>
> Best regards,
> --
> Ricardo Ribalda <[email protected]>
>