2008-02-20 00:15:47

by Adrian Bunk

Subject: [2.6 patch] net/phy/mdio_bus.c: fix a check-after-use

This patch fixes a check-after-use spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <[email protected]>

---
6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 6e9f619..963630c 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -49,13 +49,13 @@ int mdiobus_register(struct mii_bus *bus)
int i;
int err = 0;

- mutex_init(&bus->mdio_lock);
-
if (NULL == bus || NULL == bus->name ||
NULL == bus->read ||
NULL == bus->write)
return -EINVAL;

+ mutex_init(&bus->mdio_lock);
+
if (bus->reset)
bus->reset(bus);

2008-02-20 16:52:56

by Jeff Garzik

Subject: Re: [2.6 patch] net/phy/mdio_bus.c: fix a check-after-use

Adrian Bunk wrote:
> This patch fixes a check-after-use spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
> 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index 6e9f619..963630c 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -49,13 +49,13 @@ int mdiobus_register(struct mii_bus *bus)
> int i;
> int err = 0;
>
> - mutex_init(&bus->mdio_lock);
> -
> if (NULL == bus || NULL == bus->name ||
> NULL == bus->read ||
> NULL == bus->write)
> return -EINVAL;
>
> + mutex_init(&bus->mdio_lock);
> +

applied