2008-11-26 15:55:12

by Hannes Eder

Subject: [PATCH] [XFS] fix sparse warning

Impact: fix sparse warning

Fix the following sparse warning:

fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression

Signed-off-by: Hannes Eder <[email protected]>
---
fs/xfs/xfs_inode.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
index c6e295e..7a828cb 100644
--- a/fs/xfs/xfs_inode.h
+++ b/fs/xfs/xfs_inode.h
@@ -323,7 +323,7 @@ static inline struct inode *VFS_I(struct xfs_inode *ip)
static inline void xfs_destroy_inode(struct xfs_inode *ip)
{
make_bad_inode(VFS_I(ip));
- return destroy_inode(VFS_I(ip));
+ destroy_inode(VFS_I(ip));
}

/*

2008-11-26 16:22:28

by Christoph Hellwig

Subject: Re: [PATCH] [XFS] fix sparse warning

On Wed, Nov 26, 2008 at 04:54:53PM +0100, Hannes Eder wrote:
> Impact: fix sparse warning
>
> Fix the following sparse warning:
>
> fs/xfs/xfs_inode.h:326:2: warning: returning void-valued expression
>
> Signed-off-by: Hannes Eder <[email protected]>
> ---
> fs/xfs/xfs_inode.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index c6e295e..7a828cb 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -323,7 +323,7 @@ static inline struct inode *VFS_I(struct xfs_inode *ip)
> static inline void xfs_destroy_inode(struct xfs_inode *ip)
> {
> make_bad_inode(VFS_I(ip));
> - return destroy_inode(VFS_I(ip));
> + destroy_inode(VFS_I(ip));
> }

Yes, this makes sense. Thanks for the patch.