2009-06-29 09:16:22

by Xiao Guangrong

Subject: [PATCH] tracing/syscall: remove redundant code

No need to call trace_wake_up() explicitly because it's called
in trace_current_buffer_unlock_commit().

Signed-off-by: Xiao Guangrong <[email protected]>
---
kernel/trace/trace_syscalls.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
index 5e57964..dd1ce2c 100644
--- a/kernel/trace/trace_syscalls.c
+++ b/kernel/trace/trace_syscalls.c
@@ -168,7 +168,6 @@ void ftrace_syscall_enter(struct pt_regs *regs)
syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);

trace_current_buffer_unlock_commit(event, 0, 0);
- trace_wake_up();
}

void ftrace_syscall_exit(struct pt_regs *regs)
@@ -194,7 +193,6 @@ void ftrace_syscall_exit(struct pt_regs *regs)
entry->ret = syscall_get_return_value(current, regs);

trace_current_buffer_unlock_commit(event, 0, 0);
- trace_wake_up();
}

static int init_syscall_tracer(struct trace_array *tr)
--
1.6.1.2

2009-06-29 11:13:44

by Frederic Weisbecker

Subject: Re: [PATCH] tracing/syscall: remove redundant code

On Mon, Jun 29, 2009 at 05:16:23PM +0800, Xiao Guangrong wrote:
> No need to call trace_wake_up() explicitly because it's called
> in trace_current_buffer_unlock_commit().
>
> Signed-off-by: Xiao Guangrong <[email protected]>
> ---
> kernel/trace/trace_syscalls.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 5e57964..dd1ce2c 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -168,7 +168,6 @@ void ftrace_syscall_enter(struct pt_regs *regs)
> syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);
>
> trace_current_buffer_unlock_commit(event, 0, 0);
> - trace_wake_up();
> }
>
> void ftrace_syscall_exit(struct pt_regs *regs)
> @@ -194,7 +193,6 @@ void ftrace_syscall_exit(struct pt_regs *regs)
> entry->ret = syscall_get_return_value(current, regs);
>
> trace_current_buffer_unlock_commit(event, 0, 0);
> - trace_wake_up();
> }
>
> static int init_syscall_tracer(struct trace_array *tr)
> --
> 1.6.1.2
>

Thanks,

Acked-by: Frederic Weisbecker <[email protected]>