The symbol ic_dev_xid is only used locally to track the device being
configured. As such, it should be static.
Signed-off-by: H Hartley Sweeten <[email protected]>
---
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index f8d04c2..374148c 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -139,7 +139,7 @@ __be32 ic_servaddr = NONE; /* Boot server IP address */
__be32 root_server_addr = NONE; /* Address of NFS server */
u8 root_server_path[256] = { 0, }; /* Path to mount as root */
-u32 ic_dev_xid; /* Device under configuration */
+static u32 ic_dev_xid; /* Device under configuration */
/* vendor class identifier */
static char vendor_class_identifier[253] __initdata;
From: "H Hartley Sweeten" <[email protected]>
Date: Fri, 16 Oct 2009 19:30:02 -0400
> The symbol ic_dev_xid is only used locally to track the device being
> configured. As such, it should be static.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
1) Your patch doesn't apply to current sources.
2) You need to CC: all networking patch submissions to
[email protected] so that your patch gets properly
tracked at http://patchwork.ozlabs.org/project/netdev/list
Thanks.
On Friday, October 16, 2009 6:04 PM, David Miller wrote:
>> The symbol ic_dev_xid is only used locally to track the device being
>> configured. As such, it should be static.
>>
>> Signed-off-by: H Hartley Sweeten <[email protected]>
>
> 1) Your patch doesn't apply to current sources.
Strange. I just did a git pull this afternoon.
bigguiness@etch:~/src/git/linux-2.6$ git show
commit 2fdc246aaf9a7fa088451ad2a72e9119b5f7f029
Merge: 7c650a0 4997811
Author: Linus Torvalds <[email protected]>
Date: Fri Oct 16 10:13:58 2009 -0700
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp:
amd64_edac: fix DRAM base and limit extraction masks, v2
What tree should network patches be based on?
> 2) You need to CC: all networking patch submissions to
> [email protected] so that your patch gets properly
> tracked at http://patchwork.ozlabs.org/project/netdev/list
Sorry about that.
Regards,
Hartley