2011-05-09 13:27:53

by Russell King - ARM Linux

[permalink] [raw]
Subject: [PATCH 0/4] Consolidate i8253 clocksource

Three architectures have an i8253 PIT clocksource, and each duplicates
the code for this. The initial patch extracts a common implementation
to drivers/clocksource, and subsequent patches convert each architecture
to use this copy.

arch/arm/include/asm/i8253.h | 15 ++++++
arch/arm/mach-footbridge/Kconfig | 2 +
arch/arm/mach-footbridge/isa-timer.c | 45 ++----------------
arch/mips/Kconfig | 1 +
arch/mips/include/asm/i8253.h | 5 ++
arch/mips/kernel/i8253.c | 78 +-----------------------------
arch/x86/Kconfig | 1 +
arch/x86/include/asm/i8253.h | 2 +
arch/x86/kernel/i8253.c | 79 +------------------------------
drivers/clocksource/Kconfig | 3 +
drivers/clocksource/Makefile | 1 +
drivers/clocksource/i8253.c | 88 ++++++++++++++++++++++++++++++++++
include/linux/clocksource.h | 2 +
13 files changed, 126 insertions(+), 196 deletions(-)


2011-05-09 23:29:38

by John Stultz

[permalink] [raw]
Subject: Re: [PATCH 0/4] Consolidate i8253 clocksource

On Mon, 2011-05-09 at 14:27 +0100, Russell King - ARM Linux wrote:
> Three architectures have an i8253 PIT clocksource, and each duplicates
> the code for this. The initial patch extracts a common implementation
> to drivers/clocksource, and subsequent patches convert each architecture
> to use this copy.

Very cool! The series looks good to me.

Although maybe should we get rid of the inb_p redefinitions in a later
cleanup?

Acked-by: John Stultz <[email protected]>

thanks
-john