2012-10-27 22:34:23

by Cesar Eduardo Barros

Subject: [PATCH] x86: remove dummy long from EFI stub

Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for
EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI
boot stub support), but forgot to remove the dummy long used by that
reloc.

Cc: Jordan Justen <[email protected]>
Cc: Matt Fleming <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Ingo Molnar <[email protected]>
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
arch/x86/boot/header.S | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
index 2a01744..8c132a6 100644
--- a/arch/x86/boot/header.S
+++ b/arch/x86/boot/header.S
@@ -476,6 +476,3 @@ die:
setup_corrupt:
.byte 7
.string "No setup signature found...\n"
-
- .data
-dummy: .long 0
--
1.7.11.7

2012-11-04 18:14:12

by Matt Fleming

Subject: Re: [PATCH] x86: remove dummy long from EFI stub

On Sat, 2012-10-27 at 20:34 -0200, Cesar Eduardo Barros wrote:
> Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for
> EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI
> boot stub support), but forgot to remove the dummy long used by that
> reloc.
>
> Cc: Jordan Justen <[email protected]>
> Cc: Matt Fleming <[email protected]>
> Cc: "H. Peter Anvin" <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
> ---
> arch/x86/boot/header.S | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 2a01744..8c132a6 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -476,6 +476,3 @@ die:
> setup_corrupt:
> .byte 7
> .string "No setup signature found...\n"
> -
> - .data
> -dummy: .long 0

This change seems fine to me. Jordan, would you mind ACKing this if
you're OK with it?

--
Matt Fleming, Intel Open Source Technology Center

2012-11-16 19:45:39

by Jordan Justen

Subject: Re: [PATCH] x86: remove dummy long from EFI stub

Reviewed-by: Jordan Justen <[email protected]>

Lee also tested with Secure Boot. (Thanks Lee)

-Jordan

On Sat, 2012-10-27 at 20:34 -0200, Cesar Eduardo Barros wrote:
> Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for
> EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI
> boot stub support), but forgot to remove the dummy long used by that
> reloc.
>
> Cc: Jordan Justen <[email protected]>
> Cc: Matt Fleming <[email protected]>
> Cc: "H. Peter Anvin" <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Signed-off-by: Cesar Eduardo Barros <[email protected]>
> ---
> arch/x86/boot/header.S | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 2a01744..8c132a6 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -476,6 +476,3 @@ die:
> setup_corrupt:
> .byte 7
> .string "No setup signature found...\n"
> -
> - .data
> -dummy: .long 0

2012-11-19 08:29:44

by Matt Fleming

Subject: Re: [PATCH] x86: remove dummy long from EFI stub

On Fri, 2012-11-16 at 11:45 -0800, Justen, Jordan L wrote:
> Reviewed-by: Jordan Justen <[email protected]>
>
> Lee also tested with Secure Boot. (Thanks Lee)

Thanks guys. I've applied this patch.

--
Matt Fleming, Intel Open Source Technology Center