2014-09-15 12:59:16

by Gowtham Anandha Babu

Subject: [PATCH] obexd/client/map: Check msg value is valid

Checks for the NULL msg-value, before passing it to the callback.
---
obexd/client/map.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/obexd/client/map.c b/obexd/client/map.c
index 520e492..fb8ebd8 100644
--- a/obexd/client/map.c
+++ b/obexd/client/map.c
@@ -1132,7 +1132,8 @@ static void msg_element(GMarkupParseContext *ctxt, const char *element,

for (parser = msg_parsers; parser && parser->name; parser++) {
if (strcasecmp(key, parser->name) == 0) {
- parser->func(msg, values[i]);
+ if(values[i])
+ parser->func(msg, values[i]);
break;
}
}
--
1.9.1

2014-09-16 07:21:37

by Luiz Augusto von Dentz

Subject: Re: [PATCH] obexd/client/map: Check msg value is valid

Hi,

On Tue, Sep 16, 2014 at 8:13 AM, Gowtham Anandha Babu
<[email protected]> wrote:
> Hi Luiz,
>
>> -----Original Message-----
>> From: Luiz Augusto von Dentz [mailto:[email protected]]
>> Sent: Monday, September 15, 2014 6:34 PM
>> To: Gowtham Anandha Babu
>> Cc: [email protected]; Dmitry Kasatkin; Bharat Panda;
>> [email protected]
>> Subject: Re: [PATCH] obexd/client/map: Check msg value is valid
>>
>> Hi,
>>
>> On Mon, Sep 15, 2014 at 3:59 PM, Gowtham Anandha Babu
>> <[email protected]> wrote:
>> > Checks for the NULL msg-value, before passing it to the callback.
>> > ---
>> > obexd/client/map.c | 3 ++-
>> > 1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/obexd/client/map.c b/obexd/client/map.c index
>> > 520e492..fb8ebd8 100644
>> > --- a/obexd/client/map.c
>> > +++ b/obexd/client/map.c
>> > @@ -1132,7 +1132,8 @@ static void msg_element(GMarkupParseContext
>> > *ctxt, const char *element,
>> >
>> > for (parser = msg_parsers; parser && parser->name; parser++) {
>> > if (strcasecmp(key, parser->name) == 0) {
>> > - parser->func(msg, values[i]);
>> > + if(values[i])
>> > + parser->func(msg, values[i]);
>> > break;
>> > }
>> > }
>> > --
>> > 1.9.1
>>
>> Ive just pushed a similar patch, but thanks anyway.
>>
>>
>> --
>> Luiz Augusto von Dentz
>
> Sorry If I am wrong, This patch is under obexd/client/map. The patch which you pushed recently is under obexd/client/mns.

Ive pushed this after fixing the coding style and the commit message, thanks.


--
Luiz Augusto von Dentz

2014-09-16 05:13:08

by Gowtham Anandha Babu

Subject: RE: [PATCH] obexd/client/map: Check msg value is valid

Hi Luiz,

> -----Original Message-----
> From: Luiz Augusto von Dentz [mailto:[email protected]]
> Sent: Monday, September 15, 2014 6:34 PM
> To: Gowtham Anandha Babu
> Cc: [email protected]; Dmitry Kasatkin; Bharat Panda;
> [email protected]
> Subject: Re: [PATCH] obexd/client/map: Check msg value is valid
>
> Hi,
>
> On Mon, Sep 15, 2014 at 3:59 PM, Gowtham Anandha Babu
> <[email protected]> wrote:
> > Checks for the NULL msg-value, before passing it to the callback.
> > ---
> > obexd/client/map.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/obexd/client/map.c b/obexd/client/map.c index
> > 520e492..fb8ebd8 100644
> > --- a/obexd/client/map.c
> > +++ b/obexd/client/map.c
> > @@ -1132,7 +1132,8 @@ static void msg_element(GMarkupParseContext
> > *ctxt, const char *element,
> >
> > for (parser = msg_parsers; parser && parser->name; parser++) {
> > if (strcasecmp(key, parser->name) == 0) {
> > - parser->func(msg, values[i]);
> > + if(values[i])
> > + parser->func(msg, values[i]);
> > break;
> > }
> > }
> > --
> > 1.9.1
>
> Ive just pushed a similar patch, but thanks anyway.
>
>
> --
> Luiz Augusto von Dentz

Sorry If I am wrong, This patch is under obexd/client/map. The patch which you pushed recently is under obexd/client/mns.

Regards,
Gowtham

2014-09-15 13:03:49

by Luiz Augusto von Dentz

Subject: Re: [PATCH] obexd/client/map: Check msg value is valid

Hi,

On Mon, Sep 15, 2014 at 3:59 PM, Gowtham Anandha Babu
<[email protected]> wrote:
> Checks for the NULL msg-value, before passing it to the callback.
> ---
> obexd/client/map.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/obexd/client/map.c b/obexd/client/map.c
> index 520e492..fb8ebd8 100644
> --- a/obexd/client/map.c
> +++ b/obexd/client/map.c
> @@ -1132,7 +1132,8 @@ static void msg_element(GMarkupParseContext *ctxt, const char *element,
>
> for (parser = msg_parsers; parser && parser->name; parser++) {
> if (strcasecmp(key, parser->name) == 0) {
> - parser->func(msg, values[i]);
> + if(values[i])
> + parser->func(msg, values[i]);
> break;
> }
> }
> --
> 1.9.1

Ive just pushed a similar patch, but thanks anyway.


--
Luiz Augusto von Dentz