2014-10-31 05:30:23

by Gowtham Anandha Babu

Subject: [PATCH] tools/sdptool: Add MAP supported features for MNS

Add MapSupportedFeatures into MNS
attribute names.
---
tools/sdptool.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/sdptool.c b/tools/sdptool.c
index f2d3068..88a52bb 100644
--- a/tools/sdptool.c
+++ b/tools/sdptool.c
@@ -239,6 +239,11 @@ static struct attrib_def mas_attrib_names[] = {
{ 0x0317, "MapSupportedFeatures", NULL, 0 },
};

+/* Name of the various MNS attributes. See BT assigned numbers */
+static struct attrib_def mns_attrib_names[] = {
+ { 0x0317, "MapSupportedFeatures", NULL, 0 },
+};
+
/* Same for the UUIDs. See BT assigned numbers */
static struct uuid_def uuid16_names[] = {
/* -- Protocols -- */
@@ -327,7 +332,8 @@ static struct uuid_def uuid16_names[] = {
{ 0x1131, "Headset (HSP)", NULL, 0 },
{ 0x1132, "Message Access (MAP) - MAS",
mas_attrib_names, N_ELEMENTS(mas_attrib_names) },
- { 0x1133, "Message Access (MAP) - MNS", NULL, 0 },
+ { 0x1133, "Message Access (MAP) - MNS",
+ mns_attrib_names, N_ELEMENTS(mns_attrib_names) },
{ 0x1134, "Message Access (MAP)", NULL, 0 },
/* ... */
{ 0x1200, "PnPInformation",
--
1.9.1

2014-11-05 05:56:19

by Gowtham Anandha Babu

Subject: RE: [PATCH] tools/sdptool: Add MAP supported features for MNS

Hi,

> -----Original Message-----
> From: Luiz Augusto von Dentz [mailto:[email protected]]
> Sent: Tuesday, November 04, 2014 5:54 PM
> To: Gowtham Anandha Babu
> Cc: [email protected]; Dmitry Kasatkin; Bharat Panda;
> [email protected]
> Subject: Re: [PATCH] tools/sdptool: Add MAP supported features for MNS
>
> Hi,
>
> On Fri, Oct 31, 2014 at 7:30 AM, Gowtham Anandha Babu
> <[email protected]> wrote:
> > Add MapSupportedFeatures into MNS
> > attribute names.
> > ---
> > tools/sdptool.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/sdptool.c b/tools/sdptool.c index f2d3068..88a52bb
> > 100644
> > --- a/tools/sdptool.c
> > +++ b/tools/sdptool.c
> > @@ -239,6 +239,11 @@ static struct attrib_def mas_attrib_names[] = {
> > { 0x0317, "MapSupportedFeatures", NULL, 0 }, };
> >
> > +/* Name of the various MNS attributes. See BT assigned numbers */
> > +static struct attrib_def mns_attrib_names[] = {
> > + { 0x0317, "MapSupportedFeatures", NULL, 0 }, };
> > +
> > /* Same for the UUIDs. See BT assigned numbers */ static struct
> > uuid_def uuid16_names[] = {
> > /* -- Protocols -- */
> > @@ -327,7 +332,8 @@ static struct uuid_def uuid16_names[] = {
> > { 0x1131, "Headset (HSP)", NULL, 0 },
> > { 0x1132, "Message Access (MAP) - MAS",
> > mas_attrib_names, N_ELEMENTS(mas_attrib_names) },
> > - { 0x1133, "Message Access (MAP) - MNS", NULL, 0 },
> > + { 0x1133, "Message Access (MAP) - MNS",
> > + mns_attrib_names, N_ELEMENTS(mns_attrib_names) },
> > { 0x1134, "Message Access (MAP)", NULL, 0 },
> > /* ... */
> > { 0x1200, "PnPInformation",
> > --
> > 1.9.1
>
> Could you please add to the patch description the MNS record output?
>
>
> --
> Luiz Augusto von Dentz

I have added the MNS record output and submitted v1 for the same.

Regards,
Gowtham

2014-11-04 12:24:25

by Luiz Augusto von Dentz

Subject: Re: [PATCH] tools/sdptool: Add MAP supported features for MNS

Hi,

On Fri, Oct 31, 2014 at 7:30 AM, Gowtham Anandha Babu
<[email protected]> wrote:
> Add MapSupportedFeatures into MNS
> attribute names.
> ---
> tools/sdptool.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tools/sdptool.c b/tools/sdptool.c
> index f2d3068..88a52bb 100644
> --- a/tools/sdptool.c
> +++ b/tools/sdptool.c
> @@ -239,6 +239,11 @@ static struct attrib_def mas_attrib_names[] = {
> { 0x0317, "MapSupportedFeatures", NULL, 0 },
> };
>
> +/* Name of the various MNS attributes. See BT assigned numbers */
> +static struct attrib_def mns_attrib_names[] = {
> + { 0x0317, "MapSupportedFeatures", NULL, 0 },
> +};
> +
> /* Same for the UUIDs. See BT assigned numbers */
> static struct uuid_def uuid16_names[] = {
> /* -- Protocols -- */
> @@ -327,7 +332,8 @@ static struct uuid_def uuid16_names[] = {
> { 0x1131, "Headset (HSP)", NULL, 0 },
> { 0x1132, "Message Access (MAP) - MAS",
> mas_attrib_names, N_ELEMENTS(mas_attrib_names) },
> - { 0x1133, "Message Access (MAP) - MNS", NULL, 0 },
> + { 0x1133, "Message Access (MAP) - MNS",
> + mns_attrib_names, N_ELEMENTS(mns_attrib_names) },
> { 0x1134, "Message Access (MAP)", NULL, 0 },
> /* ... */
> { 0x1200, "PnPInformation",
> --
> 1.9.1

Could you please add to the patch description the MNS record output?


--
Luiz Augusto von Dentz