2014-10-15 13:41:49

by Vikrampal Yadav

Subject: [PATCH] monitor: Fix indentation for AVRCP PASS THROUGH commands

Intendation for AVRCP PASS THROUGH commands' decoding fixed.

btmon snippets:

Channel: 66 len 14 [PSM 23 mode 0] {chan 3}
AVCTP Control: Command: type 0x00 label 0 PID 0x110e
AV/C: Status: address 0x48 opcode 0x7c
Subunit: Panel
Opcode: Passthrough
Operation: 0x44 (PLAY Pressed)
Lenght: 0x00
---
monitor/avctp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/monitor/avctp.c b/monitor/avctp.c
index a4e34c5..4abd18f 100644
--- a/monitor/avctp.c
+++ b/monitor/avctp.c
@@ -686,13 +686,13 @@ static bool avrcp_passthrough_packet(struct avctp_frame *avctp_frame,
if (!l2cap_frame_get_u8(frame, &op))
return false;

- print_field("%*cOperation: 0x%02x (%s %s)", (indent - 2), ' ', op,
+ print_field("%*cOperation: 0x%02x (%s %s)", (indent - 8), ' ', op,
op2str(op), op & 0x80 ? "Released" : "Pressed");

if (!l2cap_frame_get_u8(frame, &len))
return false;

- print_field("%*cLength: 0x%02x", (indent - 2), ' ', len);
+ print_field("%*cLength: 0x%02x", (indent - 8), ' ', len);

packet_hexdump(frame->data, frame->size);
return true;
--
1.9.1

2014-10-15 14:09:07

by Vikrampal Yadav

Subject: RE: [PATCH] monitor: Fix indentation for AVRCP PASS THROUGH commands

Sure Luiz, Thanks!

> -----Original Message-----
> From: Luiz Augusto von Dentz [mailto:[email protected]]
> Sent: Wednesday, October 15, 2014 7:16 PM
> To: Vikrampal Yadav
> Cc: [email protected]; Dmitry Kasatkin; [email protected]
> Subject: Re: [PATCH] monitor: Fix indentation for AVRCP PASS THROUGH
> commands
>
> Hi Vikram,
>
> On Wed, Oct 15, 2014 at 4:41 PM, Vikrampal Yadav
> <[email protected]> wrote:
> > Intendation for AVRCP PASS THROUGH commands' decoding fixed.
> >
> > btmon snippets:
> >
> > Channel: 66 len 14 [PSM 23 mode 0] {chan 3}
> > AVCTP Control: Command: type 0x00 label 0 PID 0x110e
> > AV/C: Status: address 0x48 opcode 0x7c
> > Subunit: Panel
> > Opcode: Passthrough
> > Operation: 0x44 (PLAY Pressed)
> > Lenght: 0x00
> > ---
> > monitor/avctp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/monitor/avctp.c b/monitor/avctp.c index a4e34c5..4abd18f
> > 100644
> > --- a/monitor/avctp.c
> > +++ b/monitor/avctp.c
> > @@ -686,13 +686,13 @@ static bool avrcp_passthrough_packet(struct
> avctp_frame *avctp_frame,
> > if (!l2cap_frame_get_u8(frame, &op))
> > return false;
> >
> > - print_field("%*cOperation: 0x%02x (%s %s)", (indent - 2), ' ', op,
> > + print_field("%*cOperation: 0x%02x (%s %s)", (indent - 8), ' ',
> > + op,
> > op2str(op), op & 0x80 ? "Released" :
> > "Pressed");
> >
> > if (!l2cap_frame_get_u8(frame, &len))
> > return false;
> >
> > - print_field("%*cLength: 0x%02x", (indent - 2), ' ', len);
> > + print_field("%*cLength: 0x%02x", (indent - 8), ' ', len);
> >
> > packet_hexdump(frame->data, frame->size);
> > return true;
> > --
> > 1.9.1
> >
>
> Applied, please make sure the patch format is 50/72 according to the
> HACKING document.
>
> --
> Luiz Augusto von Dentz

Regards,
Vikram

2014-10-15 13:45:55

by Luiz Augusto von Dentz

Subject: Re: [PATCH] monitor: Fix indentation for AVRCP PASS THROUGH commands

Hi Vikram,

On Wed, Oct 15, 2014 at 4:41 PM, Vikrampal Yadav <[email protected]> wrote:
> Intendation for AVRCP PASS THROUGH commands' decoding fixed.
>
> btmon snippets:
>
> Channel: 66 len 14 [PSM 23 mode 0] {chan 3}
> AVCTP Control: Command: type 0x00 label 0 PID 0x110e
> AV/C: Status: address 0x48 opcode 0x7c
> Subunit: Panel
> Opcode: Passthrough
> Operation: 0x44 (PLAY Pressed)
> Lenght: 0x00
> ---
> monitor/avctp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/monitor/avctp.c b/monitor/avctp.c
> index a4e34c5..4abd18f 100644
> --- a/monitor/avctp.c
> +++ b/monitor/avctp.c
> @@ -686,13 +686,13 @@ static bool avrcp_passthrough_packet(struct avctp_frame *avctp_frame,
> if (!l2cap_frame_get_u8(frame, &op))
> return false;
>
> - print_field("%*cOperation: 0x%02x (%s %s)", (indent - 2), ' ', op,
> + print_field("%*cOperation: 0x%02x (%s %s)", (indent - 8), ' ', op,
> op2str(op), op & 0x80 ? "Released" : "Pressed");
>
> if (!l2cap_frame_get_u8(frame, &len))
> return false;
>
> - print_field("%*cLength: 0x%02x", (indent - 2), ' ', len);
> + print_field("%*cLength: 0x%02x", (indent - 8), ' ', len);
>
> packet_hexdump(frame->data, frame->size);
> return true;
> --
> 1.9.1
>

Applied, please make sure the patch format is 50/72 according to the
HACKING document.

--
Luiz Augusto von Dentz