Fix the following memory leak that occurs in the case of
g_dbus_register_interface(..., MEDIA_PLAYER_INTERFACE, ...) fails.
120 (104 direct, 16 indirect) bytes in 1 blocks are definitely lost in loss record 197 of 235
at 0x4C2FB55: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x50D2770: g_malloc0 (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2)
by 0x43817A: create_ct_player (avrcp.c:3331)
by 0x439928: avrcp_addressed_player_changed (avrcp.c:3639)
by 0x439928: avrcp_handle_event (avrcp.c:3716)
by 0x42F738: control_response (avctp.c:840)
by 0x42F738: session_cb (avctp.c:1005)
by 0x50CD049: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2)
by 0x50CD3EF: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2)
by 0x50CD711: g_main_loop_run (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2)
by 0x40CD10: main (main.c:778)
---
Changes in v2:
- Rewrite the commit message.
profiles/audio/avrcp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 2c1434d..eaba210 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -3335,8 +3335,11 @@ static struct avrcp_player *create_ct_player(struct avrcp *session,
path = device_get_path(session->dev);
mp = media_player_controller_create(path, id);
- if (mp == NULL)
+ if (mp == NULL) {
+ g_slist_free(player->sessions);
+ g_free(player);
return NULL;
+ }
media_player_set_callbacks(mp, &ct_cbs, player);
player->user_data = mp;
--
2.7.4