2016-02-08 14:59:05

by Syam Sidhardhan

Subject: Re: [PATCH 1/1] obexd: client: Fix memory leaks

DQpIaSwNCi0tLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLS0tDQpTZW5kZXIgOiBTWUFNIFNJ
REhBUkRIQU48cy5zeWFtQHNhbXN1bmcuY29tPiAuL1NlbmlvciBDaGllZiBFbmdpbmVlci9TUkkt
QmFuZ2Fsb3JlLVN5c3RlbSAmIENvbm5lY3Rpdml0eS9TYW1zdW5nIEVsZWN0cm9uaWNzDQpEYXRl
IDogRmViIDAzLCAyMDE2IDE5OjUyIChHTVQrMDU6MzApDQpUaXRsZSA6IFtQQVRDSCAxLzFdIG9i
ZXhkOiBjbGllbnQ6IEZpeCBtZW1vcnkgbGVha3MNCg0KV2UgaGF2ZSB0byBmcmVlIHRoZSBhbGxv
Y2F0ZWQgbWVtb3J5IGZvciBkYXRhIGFuZCBpdHMgbWVtYmVycy4NCi0tLQ0Kb2JleGQvY2xpZW50
L3Nlc3Npb24uYyB8ICAgIDEgKw0KMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspDQoNCmRp
ZmYgLS1naXQgYS9vYmV4ZC9jbGllbnQvc2Vzc2lvbi5jIGIvb2JleGQvY2xpZW50L3Nlc3Npb24u
Yw0KaW5kZXggZWY5OThmOS4uNWY5ODFiZiAxMDA2NDQNCi0tLSBhL29iZXhkL2NsaWVudC9zZXNz
aW9uLmMNCisrKyBiL29iZXhkL2NsaWVudC9zZXNzaW9uLmMNCkBAIC0xMTc5LDYgKzExNzksNyBA
QCBndWludCBvYmNfc2Vzc2lvbl9zZXRwYXRoKHN0cnVjdCBvYmNfc2Vzc2lvbiAqc2Vzc2lvbiwg
Y29uc3QgY2hhciAqcGF0aCwNCmlmICghZGF0YS0+cmVtYWluaW5nIHx8ICFkYXRhLT5yZW1haW5p
bmdbMF0pIHsNCmVycm9yKCJvYmNfc2Vzc2lvbl9zZXRwYXRoOiBpbnZhbGlkIHBhdGggJXMiLCBw
YXRoKTsNCmdfc2V0X2Vycm9yKGVyciwgT0JFWF9JT19FUlJPUiwgLUVJTlZBTCwgIkludmFsaWQg
YXJndW1lbnQiKTsNCisgc2V0cGF0aF9kYXRhX2ZyZWUoZGF0YSk7DQpyZXR1cm4gMDsNCn0NCg0K
cGluZw==

2016-02-11 14:13:36

by Luiz Augusto von Dentz

Subject: Re: [PATCH 1/1] obexd: client: Fix memory leaks

Hi Syam,

On Mon, Feb 8, 2016 at 4:59 PM, SYAM SIDHARDHAN <[email protected]> wrote:
>
> Hi,
> ------- Original Message -------
> Sender : SYAM SIDHARDHAN<[email protected]> ./Senior Chief Engineer/SRI-Bangalore-System & Connectivity/Samsung Electronics
> Date : Feb 03, 2016 19:52 (GMT+05:30)
> Title : [PATCH 1/1] obexd: client: Fix memory leaks
>
> We have to free the allocated memory for data and its members.
> ---
> obexd/client/session.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/obexd/client/session.c b/obexd/client/session.c
> index ef998f9..5f981bf 100644
> --- a/obexd/client/session.c
> +++ b/obexd/client/session.c
> @@ -1179,6 +1179,7 @@ guint obc_session_setpath(struct obc_session *session, const char *path,
> if (!data->remaining || !data->remaining[0]) {
> error("obc_session_setpath: invalid path %s", path);
> g_set_error(err, OBEX_IO_ERROR, -EINVAL, "Invalid argument");
> + setpath_data_free(data);
> return 0;
> }

Applied, thanks.


--
Luiz Augusto von Dentz