2010-01-03 18:46:37

by Przemo Firszt

[permalink] [raw]
Subject: [PATCH] Fix pad button definition in hid-wacom.c

Hi,
Please check attached patch and apply if it's possible.
The patch was also discussed here:
http://www.mail-archive.com/[email protected]/msg00128.htm

--
Regards,
Przemo Firszt


Attachments:
0001-Fix-pad-button-definition-in-hid-wacom.c.patch (916.00 B)

2010-01-12 13:36:36

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH] Fix pad button definition in hid-wacom.c

On Sun, 10 Jan 2010, Ping wrote:

> >> There is one more change required to get the pad buttons on wacom
> >> bluetooth tablet fully working - see attached patch.
>
> The patch below is needed for Wacom X.Org driver to receive the proper
> PAD button events. It is based on Przemo's applied patch attached to
> this email sting.
>
> Signed-off-by: Ping Cheng <[email protected]>
>
> --- hid-wacom.c_old 2010-01-10 10:25:48.236272275 -0800
> +++ hid-wacom.c 2010-01-10 10:25:45.216272921 -0800
> @@ -197,6 +197,9 @@
> /* Pad */
> input->evbit[0] |= BIT(EV_MSC);
> input->mscbit[0] |= BIT(MSC_SERIAL);
> + set_bit(BTN_0, input->keybit);
> + set_bit(BTN_1, input->keybit);
> + set_bit(BTN_TOOL_FINGER, input->keybit);
>
> /* Distance, rubber and mouse */
> input->absbit[0] |= BIT(ABS_DISTANCE);

Hi,

thanks for the patch. Przemo has already submitted this exact fix already,
and I have it queued in my tree.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.

2010-01-10 18:35:21

by Ping Cheng

[permalink] [raw]
Subject: Re: [PATCH] Fix pad button definition in hid-wacom.c

2010/1/9 Jiri Kosina <[email protected]>:
> On Sat, 9 Jan 2010, Przemys=C5=82aw Firszt wrote:
>
>> There is one more change required to get the pad buttons on wacom
>> bluetooth tablet fully working - see attached patch.
>
> Applied, thanks.
>
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
>

The patch below is needed for Wacom X.Org driver to receive the proper
PAD button events. It is based on Przemo's applied patch attached to
this email sting.

Signed-off-by: Ping Cheng <[email protected]>

--- hid-wacom.c_old 2010-01-10 10:25:48.236272275 -0800
+++ hid-wacom.c 2010-01-10 10:25:45.216272921 -0800
@@ -197,6 +197,9 @@
/* Pad */
input->evbit[0] |=3D BIT(EV_MSC);
input->mscbit[0] |=3D BIT(MSC_SERIAL);
+ set_bit(BTN_0, input->keybit);
+ set_bit(BTN_1, input->keybit);
+ set_bit(BTN_TOOL_FINGER, input->keybit);

/* Distance, rubber and mouse */
input->absbit[0] |=3D BIT(ABS_DISTANCE);

2010-01-09 14:16:11

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH] Fix pad button definition in hid-wacom.c

On Sat, 9 Jan 2010, Przemysław Firszt wrote:

> There is one more change required to get the pad buttons on wacom
> bluetooth tablet fully working - see attached patch.

Applied, thanks.

--
Jiri Kosina
SUSE Labs, Novell Inc.

2010-01-09 14:11:09

by Przemo Firszt

[permalink] [raw]
Subject: Re: [PATCH] Fix pad button definition in hid-wacom.c

Dnia 2010-01-04, pon o godzinie 16:39 +0100, Bastien Nocera pisze:
> On Mon, 2010-01-04 at 12:24 +0100, Jiri Kosina wrote:
> > On Sun, 3 Jan 2010, Przemysław Firszt wrote:
> >
> > > Please check attached patch and apply if it's possible.
> > > The patch was also discussed here:
> > > http://www.mail-archive.com/[email protected]/msg00128.htm
> >
> > Adding Bastien (the author of hid-wacom.c) to CC.
[..]
There is one more change required to get the pad buttons on wacom
bluetooth tablet fully working - see attached patch.
My main goal was to map pad buttons to Ctrl-Z and Ctrl-Y - (gimp
undo/redo) and now it works.
After this:
xsetwacom --set "WACOM Pen Tablet pad" Button1 "core key ctrl z"
xsetwacom --set "WACOM Pen Tablet pad" Button2 "core key ctrl y"
I've got nicely working undo/redo in gimp.
--
Przemo




Attachments:
0002-Add-BTN_TOOL_FINGER-input-report-when-reporting-a-pa.patch (1.00 kB)

2010-01-04 15:39:06

by Bastien Nocera

[permalink] [raw]
Subject: Re: [PATCH] Fix pad button definition in hid-wacom.c

On Mon, 2010-01-04 at 12:24 +0100, Jiri Kosina wrote:
> On Sun, 3 Jan 2010, Przemysław Firszt wrote:
>
> > Please check attached patch and apply if it's possible.
> > The patch was also discussed here:
> > http://www.mail-archive.com/[email protected]/msg00128.htm
>
> Adding Bastien (the author of hid-wacom.c) to CC.

I'm on the list already :)

> I have queued the patch in my tree, thanks.

Looks good, thanks for the patch!

Cheers

2010-01-04 11:24:54

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH] Fix pad button definition in hid-wacom.c

On Sun, 3 Jan 2010, Przemysław Firszt wrote:

> Please check attached patch and apply if it's possible.
> The patch was also discussed here:
> http://www.mail-archive.com/[email protected]/msg00128.htm

Adding Bastien (the author of hid-wacom.c) to CC.

I have queued the patch in my tree, thanks.

--
Jiri Kosina
SUSE Labs, Novell Inc.