2010-03-08 23:01:32

by Vinicius Costa Gomes

[permalink] [raw]
Subject: [PATCH] Fix compilation when --enable-test is passed

When --enable-test is passed along with --disable-alsa and
--disable-gstreamer, the SBC lib is not built, which breaks
compilation of the ipctest test program.
---
acinclude.m4 | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/acinclude.m4 b/acinclude.m4
index 2e4444d..0eaf236 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -316,7 +316,8 @@ AC_DEFUN([AC_ARG_BLUEZ], [

AM_CONDITIONAL(SNDFILE, test "${sndfile_enable}" = "yes" && test "${sndfile_found}" = "yes")
AM_CONDITIONAL(USB, test "${usb_enable}" = "yes" && test "${usb_found}" = "yes")
- AM_CONDITIONAL(SBC, test "${alsa_enable}" = "yes" || test "${gstreamer_enable}" = "yes")
+ AM_CONDITIONAL(SBC, test "${alsa_enable}" = "yes" || test "${gstreamer_enable}" = "yes" ||
+ test "${test_enable}" = "yes")
AM_CONDITIONAL(ALSA, test "${alsa_enable}" = "yes" && test "${alsa_found}" = "yes")
AM_CONDITIONAL(GSTREAMER, test "${gstreamer_enable}" = "yes" && test "${gstreamer_found}" = "yes")
AM_CONDITIONAL(AUDIOPLUGIN, test "${audio_enable}" = "yes")
--
1.7.0



2010-03-09 20:53:20

by Pacho Ramos

[permalink] [raw]
Subject: Re: [PATCH] Fix compilation when --enable-test is passed

El lun, 08-03-2010 a las 20:01 -0300, Vinicius Costa Gomes escribió:
> When --enable-test is passed along with --disable-alsa and
> --disable-gstreamer, the SBC lib is not built, which breaks
> compilation of the ipctest test program.
> ---
> acinclude.m4 | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index 2e4444d..0eaf236 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -316,7 +316,8 @@ AC_DEFUN([AC_ARG_BLUEZ], [
>
> AM_CONDITIONAL(SNDFILE, test "${sndfile_enable}" = "yes" && test "${sndfile_found}" = "yes")
> AM_CONDITIONAL(USB, test "${usb_enable}" = "yes" && test "${usb_found}" = "yes")
> - AM_CONDITIONAL(SBC, test "${alsa_enable}" = "yes" || test "${gstreamer_enable}" = "yes")
> + AM_CONDITIONAL(SBC, test "${alsa_enable}" = "yes" || test "${gstreamer_enable}" = "yes" ||
> + test "${test_enable}" = "yes")
> AM_CONDITIONAL(ALSA, test "${alsa_enable}" = "yes" && test "${alsa_found}" = "yes")
> AM_CONDITIONAL(GSTREAMER, test "${gstreamer_enable}" = "yes" && test "${gstreamer_found}" = "yes")
> AM_CONDITIONAL(AUDIOPLUGIN, test "${audio_enable}" = "yes")

Thanks a lot for the patch, I will try it as soon as I am able to :-)

Attachments:
signature.asc (198.00 B)
Esta parte del mensaje est? firmada digitalmente

2010-03-09 00:35:48

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Fix compilation when --enable-test is passed

Hi Vinicius,

> When --enable-test is passed along with --disable-alsa and
> --disable-gstreamer, the SBC lib is not built, which breaks
> compilation of the ipctest test program.
> ---
> acinclude.m4 | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)

patch has been applied. Thanks.

Regards

Marcel